This is a pretty massive update. I don't expect a
review of all the patches, but glancing over
the Makefiles would nice to make sure I didn't do
anything stupid.
Details
Details
- Reviewers
bapt flo - Commits
- rP391942: Update devel/ice, devel/py-ice and devel/php5-ice to 3.6.0
poudriere build logs are available at
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201143
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| devel/ice/Makefile | ||
|---|---|---|
| 54 ↗ | (On Diff #6521) | This is already done by bsd.prt.mk (only the -g) not what is done in else |
| 60 ↗ | (On Diff #6521) | BROKEN_ia64= ... |
| devel/php5-ice/Makefile | ||
| 28 ↗ | (On Diff #6521) | This should never ever be done in a port Makefile! this is a user setting not a port setting |
Comment Actions
Changes based on @bapt's comments
| devel/php5-ice/Makefile | ||
|---|---|---|
| 28 ↗ | (On Diff #6521) | I assume that's also true for what's been there before. One thing I noticed: After removing the line, the package is built using PHP 5.6 (before it was 5.4). So it seems like the default PHP version is 5.6, but the defalt PHP5 version is 5.4. Seems a bit counter intuitive to me (bsd.php.mk equates 5.4 with and then says PHP5_LAST_VER= 54). |
Comment Actions
Further improvements to the port, some of which will be reported
to upstream.
- Drop user privileges in unit tests for those which shouldn't be run as root, so that all unit tests are run when building as root (especially in poudriere).
- Refactor the previous patch to IceGrid's PluginFactoryI to fix invalid use of static deinitialization, while still using static initialization, so that custom load balancing plugins will still work.
- Fix bug which broke SOCKS and HTTP proxies in case of (POSIX compliant) synchronous calls to connect(2). Thanks to Roger Leigh for reporting and testing.