Page MenuHomeFreeBSD

Update devel/ice, devel/py-ice and devel/php5-ice to 3.6.0
ClosedPublic

Authored by grembo on Jun 28 2015, 12:13 PM.

Details

Summary

This is a pretty massive update. I don't expect a
review of all the patches, but glancing over
the Makefiles would nice to make sure I didn't do
anything stupid.

Test Plan

poudriere build logs are available at
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201143

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

grembo retitled this revision from to Update devel/ice, devel/py-ice and devel/php5-ice to 3.6.0.
grembo updated this object.
grembo edited the test plan for this revision. (Show Details)
grembo added a reviewer: bapt.

Can we see the build logs?

There's a link to the PR under "Test plan", which has the build logs.

bapt requested changes to this revision.Jun 29 2015, 6:10 AM
bapt edited edge metadata.
bapt added inline comments.
devel/ice/Makefile
54 ↗(On Diff #6521)

This is already done by bsd.prt.mk (only the -g) not what is done in else

60 ↗(On Diff #6521)

BROKEN_ia64= ...
same for aboves ones :)

devel/php5-ice/Makefile
28 ↗(On Diff #6521)

This should never ever be done in a port Makefile! this is a user setting not a port setting

This revision now requires changes to proceed.Jun 29 2015, 6:10 AM
grembo edited edge metadata.
grembo marked 3 inline comments as done.

Changes based on @bapt's comments

devel/php5-ice/Makefile
28 ↗(On Diff #6521)

I assume that's also true for what's been there before.

One thing I noticed: After removing the line, the package is built using PHP 5.6 (before it was 5.4). So it seems like the default PHP version is 5.6, but the defalt PHP5 version is 5.4. Seems a bit counter intuitive to me (bsd.php.mk equates 5.4 with and then says PHP5_LAST_VER= 54).

grembo edited edge metadata.

Fix static initialization order fiasco in icegridnode and icegridregistry.

Further improvements to the port, some of which will be reported
to upstream.

  • Drop user privileges in unit tests for those which shouldn't be run as root, so that all unit tests are run when building as root (especially in poudriere).
  • Refactor the previous patch to IceGrid's PluginFactoryI to fix invalid use of static deinitialization, while still using static initialization, so that custom load balancing plugins will still work.
  • Fix bug which broke SOCKS and HTTP proxies in case of (POSIX compliant) synchronous calls to connect(2). Thanks to Roger Leigh for reporting and testing.
bapt edited edge metadata.
This revision is now accepted and ready to land.Jul 4 2015, 1:50 PM
This revision was automatically updated to reflect the committed changes.