Paths

Table of Contentst

Differential D29019

kvm_nlist(3) leaks allocated memory
ClosedPublic
Actions

Authored by jkim on Mar 2 2021, 7:59 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Aug 22, 7:33 AM

	Unknown Object (File)
	Sat, Aug 22, 4:37 AM

	Unknown Object (File)
	Sat, Aug 15, 6:45 PM

	Unknown Object (File)
	Tue, Aug 11, 3:35 PM

	Unknown Object (File)
	Tue, Aug 11, 10:20 AM

	Unknown Object (File)
	Tue, Aug 11, 2:48 AM

	Unknown Object (File)
	Mon, Aug 10, 12:37 PM

	Unknown Object (File)
	Mon, Aug 10, 11:17 AM

Subscribers

None

Details

Reviewers

jhb
rwatson

Commits

rG859105d755ce: libkvm: Plug couple of memory leaks and check possible calloc(3) failure
rGeda8f0575dda: libkvm: Plug couple of memory leaks and check possible calloc(3) failure
rG24ee1eb2b680: libkvm: Plug couple of memory leaks and check possible calloc(3) failure
rG645eaa2ccaed: libkvm: Plug couple of memory leaks and check possible calloc(3) failure

Summary

A user reported kvm_nlist(3) leaks memory. I found there are two leaks. First, it had to free(3) dpcpu_off (introduced in rS204494) from kvm_close(3). Second, it is not free()'ing temporary buffer introduced in D3341 (rS291406). Also, an unchecked calloc(3) failure was fixed while I am in the neighborhood.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jkim requested review of this revision.Mar 2 2021, 7:59 PM

jkim created this revision.

jkim updated this revision to Diff 85081.Mar 3 2021, 10:08 PM

jkim edited the summary of this revision. (Show Details)

jkim added a reviewer: rwatson.

All looks good to me.

This revision is now accepted and ready to land.Mar 3 2021, 10:40 PM

Closed by commit rG645eaa2ccaed: libkvm: Plug couple of memory leaks and check possible calloc(3) failure (authored by jkim). · Explain WhyMar 3 2021, 11:18 PM

This revision was automatically updated to reflect the committed changes.

jkim added a commit: rG645eaa2ccaed: libkvm: Plug couple of memory leaks and check possible calloc(3) failure.

jkim added a commit: rG24ee1eb2b680: libkvm: Plug couple of memory leaks and check possible calloc(3) failure.Mar 6 2021, 7:38 PM

jkim added a commit: rGeda8f0575dda: libkvm: Plug couple of memory leaks and check possible calloc(3) failure.

jkim added a commit: rG859105d755ce: libkvm: Plug couple of memory leaks and check possible calloc(3) failure.Mar 6 2021, 8:05 PM

Revision Contents
Changeset List

Path

Size

lib/

libkvm/

7 lines

Diff 85085

lib/libkvm/kvm.c

Loading...