libifconfig: Fix handling of malloc fail in ifconfig_get_groups
ClosedPublic
Actions

Authored by freqlabs on Feb 27 2021, 8:22 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 12, 6:52 AM

	Unknown Object (File)
	Mon, May 4, 3:16 PM

	Unknown Object (File)
	Mon, May 4, 8:57 AM

	Unknown Object (File)
	Sun, May 3, 6:56 PM

	Unknown Object (File)
	Sun, May 3, 6:13 PM

	Unknown Object (File)
	Thu, Apr 30, 7:58 AM

	Unknown Object (File)
	Tue, Apr 28, 3:39 PM

	Unknown Object (File)
	Sun, Apr 26, 12:51 AM

View All Files

Subscribers

None

Details

Reviewers

Commits

rG0fed2239730f: libifconfig: Set error in ifconfig_get_groups
rG1d9ba697f99a: libifconfig: Set error in ifconfig_get_groups

Summary

This should return -1 with OTHER/ENOMEM set in the handle, like everywhere else.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

freqlabs requested review of this revision.Feb 27 2021, 8:22 AM

freqlabs created this revision.

freqlabs added a child revision: D28965: sbin/ifconfig: Use libifconfig to get groups.Feb 27 2021, 8:26 AM

kp accepted this revision.Feb 27 2021, 4:07 PM

This revision is now accepted and ready to land.Feb 27 2021, 4:07 PM

Closed by commit rG1d9ba697f99a: libifconfig: Set error in ifconfig_get_groups (authored by freqlabs). · Explain WhyFeb 27 2021, 11:16 PM

This revision was automatically updated to reflect the committed changes.

freqlabs added a commit: rG1d9ba697f99a: libifconfig: Set error in ifconfig_get_groups.

freqlabs added a commit: rG0fed2239730f: libifconfig: Set error in ifconfig_get_groups.Mar 14 2021, 9:10 AM

Revision Contents
Changeset List

Path

Size

lib/

libifconfig/

libifconfig.c

4 lines

Diff 84817

View Options

lib/libifconfig/libifconfig.c

libifconfig: Fix handling of malloc fail in ifconfig_get_groupsClosedPublicActions