Page MenuHomeFreeBSD
Differential D28928

articles/committers-guide: fix README link
ClosedPublic
Actions

Authored by fernape on Feb 25 2021, 7:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 31, 7:03 AM
Unknown Object (File)
Mar 5 2024, 1:12 AM
Unknown Object (File)
Mar 4 2024, 8:22 AM
Unknown Object (File)
Jan 14 2024, 10:42 PM
Unknown Object (File)
Dec 29 2023, 1:27 AM
Unknown Object (File)
Dec 22 2023, 10:54 PM
Unknown Object (File)
Nov 18 2023, 5:50 PM
Unknown Object (File)
Nov 18 2023, 5:20 PM
View All 26 Files
Subscribers
None

Details

Reviewers
0mp
gbe
Commits
R9:745eae659f01: articles/committers-guide: fix README link
Summary

Fix addkeys.sh README link.

Current link in Committer's Guide for the README of the addkeys.sh script is
broken.

It can be seen here:
https://docs.freebsd.org/en/articles/committers-guide/#commit-steps

It points to http://svnweb.freebsd.org/doc/head/shared/pgpkeys/README which
returns 404. It should point to https://docs.freebsd.org/pgpkeys/README.

Test Plan
  • Apply patch
  • Run make from documentation root
  • Go to Committer's Guide and check the new link.

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fernape requested review of this revision.Feb 25 2021, 7:00 PM
fernape created this revision.
Harbormaster completed remote builds in B37377: Diff 84702.Feb 25 2021, 7:00 PM
fernape added a comment.Feb 25 2021, 9:48 PM

Sorry, this is not completely right. It should be somehow relative to the doc structure. I'm trying to figure it out.

fernape updated this revision to Diff 84735.Feb 26 2021, 8:18 AM

Properly constructing the link.

Mimic what is done in the handbook.

Harbormaster completed remote builds in B37400: Diff 84735.Feb 26 2021, 8:18 AM
fernape added a comment.Feb 28 2021, 5:58 PM

Sorry, this is not completely right. It should be somehow relative to the doc structure. I'm trying to figure it out.

0mp added a comment.Apr 18 2021, 1:41 PM

Hi there, any progress on this one?

fernape updated this revision to Diff 87660.Apr 18 2021, 5:17 PM
  • Fix link properly

I thought I had updated this but clearely I did not!

The original link was poiting to svnweb and hence returned a 404.
Now, we can not use a relative link because:

  • In my first approach, I linked to the doc repo and not the generated documents
  • The README is not in the generated documents set (i.e: the public dir)

So link agains the file in the repo as it was originally and just fix the URL.

Harbormaster completed remote builds in B38667: Diff 87660.Apr 18 2021, 5:17 PM
0mp accepted this revision.Apr 18 2021, 5:32 PM

*shipit*

This revision is now accepted and ready to land.Apr 18 2021, 5:32 PM
Closed by commit R9:745eae659f01: articles/committers-guide: fix README link (authored by fernape). · Explain WhyApr 18 2021, 5:53 PM
This revision was automatically updated to reflect the committed changes.
fernape added a commit: R9:745eae659f01: articles/committers-guide: fix README link.

Revision Contents
Changeset List

PathSize
documentation/
content/
en/
articles/
committers-guide/
2 lines

Diff 87663

View Options

documentation/content/en/articles/committers-guide/_index.adoc

Loading...