amd64: import asm strlen into libc
ClosedPublic
Actions

Authored by mjg on Sun, Feb 21, 9:29 PM.

Details

Reviewers

kib
jhb

Commits

R10:7f06b217c53c: amd64: import asm strlen into libc

Diff Detail

Repository

R10 FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mjg requested review of this revision.Sun, Feb 21, 9:29 PM

mjg created this revision.

kib added inline comments.Mon, Feb 22, 9:51 PM

lib/libc/amd64/string/strlen.S
2	I do not think this is valid notice form about 'public domain'. At very least it should specify who wrote the code and put it into the public domain. Look for other examples in the tree.
14	Why redefining this instead of including machine/asmacros.h ?

update license

Adding the header fails to compile with:

In file included from /usr/src/lib/libc/amd64/string/strlen.S:7:
/usr/include/machine/asm.h:88:9: error: 'ALTENTRY' macro redefined [-Werror,-Wmacro-redefined]
#define ALTENTRY(x)     _ENTRY(x)
        ^

with a host of other errors

Using it instead of asm.h results in:

/usr/src/lib/libc/amd64/string/strlen.S:8:22: error: expected ')' in parentheses expression
__asm__(".ident\t\"" "$FreeBSD$" "\"");
                     ^

someone(tm) needs to clean this up and I don't think it's worth the effort now

kib accepted this revision.Mon, Feb 22, 10:57 PM

This revision is now accepted and ready to land.Mon, Feb 22, 10:57 PM

Closed by commit R10:7f06b217c53c: amd64: import asm strlen into libc (authored by mjg). · Explain WhyTue, Feb 23, 12:11 AM

This revision was automatically updated to reflect the committed changes.

mjg added a commit: R10:7f06b217c53c: amd64: import asm strlen into libc.