ddb: get the unwinder to handle function prologue/epilogue exceptions

[markj]

Summary

The trapframe argument to db_backtrace() was previously always NULL, so
this code was never executing. Modify db_trace_thread() to pass
kdb_frame if we're being asked to trace kdb_thread's stack.

Get rid of get_rsp(). It looks like this came over from i386, which
needs to take into account whether the exception triggered a CPL switch,
since SS:ESP is only pushed onto the stack if so. On amd64, SS:RSP is
pushed regardless of whether the CPL changed, so get_rsp() was doing the
wrong thing for exceptions in ring 0.

Test Plan

Tested on amd64 and i386 by placing breakpoints on a sysctl handler and making sure that we get the right backtrace when:

• the bp is on the first instruction (push rbp)
• the bp is on the second instruction (mov rsp, rbp)
• the bp is on a ret instruction, after a "pop rbp"

[jhb]

sys/amd64/amd64/db_trace.c

150 ↗

(On Diff #6370)

Good catch on removing get_rsp(). However, I think you can remove db_rsp entirely and just use db_frame.

Is the same true of db_ss() btw? Ah, it is. You can remove db_ss() and just use db_frame() to read/write tf_ss as well.

[markj]

• Remove more unneeded special handling of SS and RSP.

sys/amd64/amd64/db_trace.c

146–147 ↗

(On Diff #7121)

Gah. Thanks!