support SO_REUSEADDR for debug port for bhyve
ClosedPublic
Actions

Authored by jmg on Jun 20 2015, 4:21 AM.

Details

Reviewers

grehan
neel

Summary

If you shutdown a bhyve instance w/ gdb attached to it, you'll
get a hanging port in TIME_WAIT preventing bind'ing to the same
port... Like all daemons, mark the socket SO_REUSEADDR so we don't
get hit by this issue...

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

jmg updated this revision to Diff 6346.Jun 20 2015, 4:21 AM

jmg retitled this revision from to support SO_REUSEADDR for debug port for bhyve.

jmg updated this object.

jmg edited the test plan for this revision. (Show Details)

jmg added reviewers: grehan, neel.

Herald added a subscriber: imp. · View Herald TranscriptJun 20 2015, 4:21 AM

grehan added inline comments.Jun 20 2015, 5:35 AM

usr.sbin/bhyve/dbgport.c
135	sizeof(reuse) ala style(9) and the code below.
136	perror("setsockopt")

address grehan's comments...

I'll match style, but I prefer to use no parens for vars, this lets
the coder know that sizeof is being used properly, where as w/ parens,
it's a type and a bug (where if the var changes types, you will have
a mismatch)...

addressed

grehan accepted this revision.Jun 20 2015, 5:50 AM

grehan edited edge metadata.

This revision is now accepted and ready to land.Jun 20 2015, 5:50 AM

committed in svn commit: r284630 - head/usr.sbin/bhyve

must not of done the review tag properly..

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

dbgport.c

9 lines

Diff 6348

View Options

support SO_REUSEADDR for debug port for bhyveClosedPublicActions