Page MenuHomeFreeBSD

Fix fget_only_user() to return ENOTCAPABLE on a failed capsicum check
ClosedPublic

Authored by arichardson on Feb 15 2021, 8:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 19, 3:25 PM
Unknown Object (File)
Tue, Mar 19, 3:23 PM
Unknown Object (File)
Mar 19 2024, 4:29 AM
Unknown Object (File)
Mar 19 2024, 2:47 AM
Unknown Object (File)
Feb 9 2024, 8:53 AM
Unknown Object (File)
Dec 14 2023, 8:19 PM
Unknown Object (File)
Dec 9 2023, 1:51 AM
Unknown Object (File)
Sep 18 2023, 1:13 PM
Subscribers

Details

Summary

After eaad8d1303da500ed691bd774742a4555a05e729 four additional
capsicum-test tests started failing. It turns out this is because
fget_only_user() was returning EBADF on a failed capsicum check instead
of forwarding the return value of cap_check_inline() like
fget_unlocked_seq().

Test Plan

capsicum-test failures before this:

[  FAILED  ] 7 tests, listed below:
[  FAILED  ] Capability.OperationsForked
[  FAILED  ] Capability.NoBypassDAC
[  FAILED  ] Pdfork.OtherUserForked
[  FAILED  ] PipePdfork.WildcardWait
[  FAILED  ] OpenatTest.WithFlag
[  FAILED  ] ForkedOpenatTest_WithFlagInCapabilityMode._
[  FAILED  ] Select.LotsOFileDescriptorsForked

After:

[  FAILED  ] 3 tests, listed below:
[  FAILED  ] Capability.NoBypassDAC
[  FAILED  ] Pdfork.OtherUserForked
[  FAILED  ] PipePdfork.WildcardWait

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable