Page MenuHomeFreeBSD

ddb: don't return undefined symbols to a lookup
ClosedPublic

Authored by markj on Jun 18 2015, 5:21 PM.
Tags
None
Referenced Files
F152691317: D2858.id7157.diff
Thu, Apr 16, 1:13 PM
Unknown Object (File)
Wed, Apr 15, 4:29 AM
Unknown Object (File)
Wed, Apr 15, 1:48 AM
Unknown Object (File)
Mon, Apr 13, 1:28 AM
Unknown Object (File)
Mon, Apr 6, 8:42 AM
Unknown Object (File)
Fri, Mar 27, 5:56 AM
Unknown Object (File)
Mon, Mar 23, 8:16 AM
Unknown Object (File)
Sun, Mar 22, 7:20 AM
Subscribers
None

Details

Summary

Undefined symbols have a value of 0, so it makes no sense to return such
a symbol when performing a lookup by value. This occurs when unwinding
the stack after calling a NULL function pointer, and we confusingly
report the current function as uart_sab82532_class() on amd64.

Convert db_print_loc_and_inst() to only attempt disassembly if we
managed to find a symbol corresponding to the IP. Otherwise we may fault
and reenter the debugger.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj retitled this revision from to ddb: don't return undefined symbols to a lookup.
markj edited the test plan for this revision. (Show Details)
markj updated this object.
jhb edited edge metadata.
This revision is now accepted and ready to land.Jun 20 2015, 2:22 PM
This revision was automatically updated to reflect the committed changes.