Page MenuHomeFreeBSD

x11/ly: Update to 0.5.0 and adopt port
ClosedPublic

Authored by nc on Feb 2 2021, 5:40 AM.

Details

Summary

x11/ly: Update to 0.5.0 and adopt port

Changes: https://github.com/nullgemm/ly/releases/tag/v0.5.0

Test Plan

Passes poudriere, tested to work.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nc requested review of this revision.Feb 2 2021, 5:40 AM

Some of the macros have been missing when I rebased the patches. Fixing that.

Just a note: I was just working on the update myself. Maybe you'll find this patch useful: https://reviews.freebsd.org/D23897

x11/ly/files/patch-res_config.ini
19 ↗(On Diff #83262)

/usr/local should be %%LOCALBASE%%.

55 ↗(On Diff #83262)

%%LOCALBASE%%

x11/ly/files/patch-src_config.c
9 ↗(On Diff #83262)

Isn't ETCDIR already $PREFIX/etc/ly?

Here's an updated diff. Thanks for pointing this out!

nc marked 2 inline comments as done.Feb 3 2021, 3:46 AM
nc marked an inline comment as done.

If it compiles and runs, it looks good to me.

Last two things:

  • In my patch it seems like the git modules of this port had to be updated. I guess it may still be desired to do it.
  • There is an open issue on GitHub which you seem to address with the patches here. Great job! https://github.com/nullgemm/ly/issues/184

It in fact does compile, even with the current GITMODULES.

OK, then. SHIP IT :D

This revision is now accepted and ready to land.Feb 5 2021, 10:59 AM
This revision was automatically updated to reflect the committed changes.