Page MenuHomeFreeBSD
Differential D28457

x11/ly: Update to 0.5.0 and adopt port
ClosedPublic
Actions

Authored by nc on Feb 2 2021, 5:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 2:05 AM
Unknown Object (File)
Tue, Apr 16, 12:57 AM
Unknown Object (File)
Tue, Apr 16, 12:57 AM
Unknown Object (File)
Tue, Apr 16, 12:57 AM
Unknown Object (File)
Tue, Apr 16, 12:57 AM
Unknown Object (File)
Tue, Apr 16, 12:57 AM
Unknown Object (File)
Fri, Apr 12, 3:03 AM
Unknown Object (File)
Mar 16 2024, 3:08 AM
View All 61 Files
Subscribers
0mp
mat

Details

Reviewers
0mp
Commits
rP564128: x11/ly: Update to 0.5.0 and adopt port
Summary

x11/ly: Update to 0.5.0 and adopt port

Changes: https://github.com/nullgemm/ly/releases/tag/v0.5.0

Test Plan

Passes poudriere, tested to work.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 36670
Build 33559: arc lint + arc unit

Event Timeline

nc created this revision.Feb 2 2021, 5:40 AM
Herald added a subscriber: mat. · View Herald TranscriptFeb 2 2021, 5:40 AM
nc requested review of this revision.Feb 2 2021, 5:40 AM
nc edited the summary of this revision. (Show Details)Feb 2 2021, 5:40 AM
Harbormaster completed remote builds in B36669: Diff 83261.Feb 2 2021, 5:41 AM
nc updated this revision to Diff 83262.Feb 2 2021, 5:45 AM

Some of the macros have been missing when I rebased the patches. Fixing that.

Harbormaster completed remote builds in B36670: Diff 83262.Feb 2 2021, 5:46 AM
0mp added a comment.Feb 2 2021, 1:44 PM

Just a note: I was just working on the update myself. Maybe you'll find this patch useful: https://reviews.freebsd.org/D23897

x11/ly/files/patch-res_config.ini
19

/usr/local should be %%LOCALBASE%%.

55

%%LOCALBASE%%

x11/ly/files/patch-src_config.c
9

Isn't ETCDIR already $PREFIX/etc/ly?

nc updated this revision to Diff 83297.Feb 3 2021, 3:46 AM

Here's an updated diff. Thanks for pointing this out!

Harbormaster completed remote builds in B36684: Diff 83297.Feb 3 2021, 3:46 AM
nc marked 2 inline comments as done.Feb 3 2021, 3:46 AM
nc marked an inline comment as done.
0mp added a comment.Feb 4 2021, 10:43 PM

If it compiles and runs, it looks good to me.

Last two things:

  • In my patch it seems like the git modules of this port had to be updated. I guess it may still be desired to do it.
  • There is an open issue on GitHub which you seem to address with the patches here. Great job! https://github.com/nullgemm/ly/issues/184
nc added a comment.Feb 5 2021, 6:23 AM

It in fact does compile, even with the current GITMODULES.

0mp accepted this revision.Feb 5 2021, 10:59 AM

OK, then. SHIP IT :D

This revision is now accepted and ready to land.Feb 5 2021, 10:59 AM
Closed by commit rP564128: x11/ly: Update to 0.5.0 and adopt port (authored by nc). · Explain WhyFeb 5 2021, 4:54 PM
This revision was automatically updated to reflect the committed changes.
nc added a commit: rP564128: x11/ly: Update to 0.5.0 and adopt port.

Revision Contents
Changeset List

Diff 83262

View Options

x11/ly/Makefile

Loading...
View Options

x11/ly/distinfo

Loading...
View Options

x11/ly/files/patch-makefile

Loading...
View Options

x11/ly/files/patch-res_config.ini

Loading...
View Options

x11/ly/files/patch-res_xsetup.sh

Loading...
View Options

x11/ly/files/patch-src_config.h

Loading...
View Options

x11/ly/files/patch-src_config.c

Loading...
View Options

x11/ly/files/patch-src_login.c

Loading...
View Options

x11/ly/pkg-plist

Loading...