Page MenuHomeFreeBSD

graphics/pngcheck: Update to 3.0.1
ClosedPublic

Authored by lcook on Jan 26 2021, 2:02 PM.

Details

Summary

Changelog:

QA:

  • portlint: OK (looks fine).
  • testport: OK (poudriere: 12.2-RELEASE, amd64/i386).

PR: 253019
Submitted by: Naram Qashat <cyberbotx@cyberbotx.com> (maintainer)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lcook requested review of this revision.Jan 26 2021, 2:02 PM

LGTM!

Mind you that the command does a funny thing in amd64. Compare the two outputs:

root@12_2i386-default:~ # pngcheck /distfiles/geogebra.png 
OK: /distfiles/geogebra.png (32x32, 64-bit RGB+alpha, non-interlaced, 51.0%).
root@12_2i386-default:~ # pngcheck -s /distfiles/geogebra.png
OK: /distfiles/geogebra-1 (32x32, 64-bit RGB+alpha, non-interlaced, 100.0%).
root@12_2amd64-default:~ # pngcheck /distfiles/geogebra.png
OK: /distfiles/geogebra.png (32x32, 64-bit RGB+alpha, non-interlaced, 51.0%).
root@12_2amd64-default:~ # pngcheck -s /distfiles/geogebra.png
OK: /distfiles/geogebra-1 (32x32, 64-bit RGB+alpha, non-interlaced, -25545.9%). <-----

I would commit this, but I would report the glitch to the maintainer ;-)

Good job!

This revision is now accepted and ready to land.Jan 27 2021, 9:07 AM
This revision was automatically updated to reflect the committed changes.