Changelog:
QA:
- portlint: OK (looks fine).
- testport: OK (poudriere: 12.2-RELEASE, amd64/i386).
PR: 253019
Submitted by: Naram Qashat <cyberbotx@cyberbotx.com> (maintainer)
Paths
| Differential D28350 Authored by lcook on Jan 26 2021, 2:02 PM.
Details
Summary Changelog: QA:
PR: 253019
Diff Detail
Event TimelineHerald added a subscriber: mat. · View Herald TranscriptJan 26 2021, 2:02 PM2021-01-26 14:02:48 (UTC+0) Harbormaster completed remote builds in B36501: Diff 82908.Jan 26 2021, 2:03 PM2021-01-26 14:03:24 (UTC+0) Comment Actions LGTM! Mind you that the command does a funny thing in amd64. Compare the two outputs: root@12_2i386-default:~ # pngcheck /distfiles/geogebra.png OK: /distfiles/geogebra.png (32x32, 64-bit RGB+alpha, non-interlaced, 51.0%). root@12_2i386-default:~ # pngcheck -s /distfiles/geogebra.png OK: /distfiles/geogebra-1 (32x32, 64-bit RGB+alpha, non-interlaced, 100.0%). root@12_2amd64-default:~ # pngcheck /distfiles/geogebra.png OK: /distfiles/geogebra.png (32x32, 64-bit RGB+alpha, non-interlaced, 51.0%). root@12_2amd64-default:~ # pngcheck -s /distfiles/geogebra.png OK: /distfiles/geogebra-1 (32x32, 64-bit RGB+alpha, non-interlaced, -25545.9%). <----- I would commit this, but I would report the glitch to the maintainer ;-) Good job! This revision is now accepted and ready to land.Jan 27 2021, 9:07 AM2021-01-27 09:07:09 (UTC+0) Closed by commit rP563038: graphics/pngcheck: Update to 3.0.1 (authored by lcook). · Explain WhyJan 27 2021, 10:29 AM2021-01-27 10:29:47 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 82966 head/graphics/pngcheck/Makefile
head/graphics/pngcheck/distinfo
|
Since you're touching that line, use https: everywhere for consistency. (I checked and all appear to work.)