Page MenuHomeFreeBSD

Fix issues in past and present CheriBSD quarterly reports
ClosedPublic

Authored by jrtc27 on Jan 21 2021, 2:36 AM.

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jrtc27 created this revision.

Fix unintended whitespace diff

Looks good to me, thank you for your attention to detail. :)

This revision is now accepted and ready to land.Jan 21 2021, 3:06 AM

Don't know if I'm supposed to be able to push with a Reviewed by: + Approved by: debdrup, or if something just hates me, but I get "FATAL: VREF/APPROVERS-CHECK/doc: helper program exit status 65280", so could you please commit this for me?

Don't know if I'm supposed to be able to push with a Reviewed by: + Approved by: debdrup, or if something just hates me, but I get "FATAL: VREF/APPROVERS-CHECK/doc: helper program exit status 65280", so could you please commit this for me?

This puzzled me, too, until I realized that it's past 02:00 UTC, which means the doc repo is read-only in preparation for the move to Hugo/AsciiDoctor, in accordance with Message-ID: <CAFwocyM9gA1iO2isXcDZTKRssF7xCbr=-iT8fPOsP_3Ctvf6tQ@mail.gmail.com>.

Admittedly, the error message is less than perfect.

Don't know if I'm supposed to be able to push with a Reviewed by: + Approved by: debdrup, or if something just hates me, but I get "FATAL: VREF/APPROVERS-CHECK/doc: helper program exit status 65280", so could you please commit this for me?

This puzzled me, too, until I realized that it's past 02:00 UTC, which means the doc repo is read-only in preparation for the move to Hugo/AsciiDoctor, in accordance with Message-ID: <CAFwocyM9gA1iO2isXcDZTKRssF7xCbr=-iT8fPOsP_3Ctvf6tQ@mail.gmail.com>.

Admittedly, the error message is less than perfect.

Ah, I hadn't twigged that it was going read-only so far in advance of the migration. The error message is technically correct I guess, needs a doceng approval, and this kind of thing is a bit of a special case.

This comment was removed by debdrup.

Ah, I hadn't twigged that it was going read-only so far in advance of the migration. The error message is technically correct I guess, needs a doceng approval, and this kind of thing is a bit of a special case.

Yeah, it looks like doceng@ approval is required, because gjb@ just made a commit and that went through.

Will you be applying for approval for this, or should I?

Or are you just going to wait past the conversion and redo it, or should I?

Ah, I hadn't twigged that it was going read-only so far in advance of the migration. The error message is technically correct I guess, needs a doceng approval, and this kind of thing is a bit of a special case.

Yeah, it looks like doceng@ approval is required, because gjb@ just made a commit and that went through.

Will you be applying for approval for this, or should I?

Or are you just going to wait past the conversion and redo it, or should I?

Ah it can wait, not much to gain from landing it a couple of days early.

Rebase against shiny new repo

This revision now requires review to proceed.Jan 26 2021, 12:46 AM

Hmph. Phabricator does not support ISO-8859-1 (their docs say so explicitly) so it balks on these files and treats them as binary. That's going to be fun.

Manually pasted reduced-context diff to work around Phabricator's UTF-8-centric views

Looks great to me, let's get this one landed post-haste (or whenever you get around to it)! :)

Thank you for your attention to detail, Jessica.

This revision is now accepted and ready to land.Jan 26 2021, 2:28 PM