Page MenuHomeFreeBSD
Differential D28130

elftcl: add -i flag to ignore unknown flags
ClosedPublic
Actions

Authored by emaste on Jan 13 2021, 3:29 AM.
Tags
None
Referenced Files
F132441409: D28130.id82186.diff
Thu, Oct 16, 11:44 PM
F132441404: D28130.id.diff
Thu, Oct 16, 11:44 PM
F132441403: D28130.id82189.diff
Thu, Oct 16, 11:44 PM
F132441398: D28130.id82187.diff
Thu, Oct 16, 11:43 PM
F132441397: D28130.id82188.diff
Thu, Oct 16, 11:43 PM
F132400812: D28130.diff
Thu, Oct 16, 2:54 PM
Unknown Object (File)
Mon, Oct 13, 10:04 PM
Unknown Object (File)
Sun, Oct 12, 6:49 AM
View All Files
Subscribers
None

Details

Reviewers
kib
markj
Commits
rG369a4023e671: elftcl: add -i flag to ignore unknown flags
rGf6d95a01103a: elftcl: add -i flag to ignore unknown flags
Summary

This may allow an identical elfctl invocation to be used on multiple FreeBSD versions, with features not implemented on older releases being silently ignored.

PR: 252629 (related)
MFC after: 1 week
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Jan 13 2021, 3:29 AM
emaste created this revision.
emaste added a reviewer: markj.
kib added inline comments.Jan 13 2021, 4:00 AM
usr.bin/elfctl/elfctl.c
207

Add -i flag there ?

236

I suggest to print something anyway, so e.g. typos are still being caught. May be add quit mode where nothing is printed at all but I am not sure it is needed.

emaste updated this revision to Diff 82187.Jan 13 2021, 4:14 AM

leave warning in place with -i, per kib

emaste updated this revision to Diff 82188.Jan 13 2021, 4:17 AM

add -i to usage, per kib

kib accepted this revision.Jan 13 2021, 5:03 AM
This revision is now accepted and ready to land.Jan 13 2021, 5:03 AM
Closed by commit rGf6d95a01103a: elftcl: add -i flag to ignore unknown flags (authored by emaste). · Explain WhyJan 13 2021, 5:12 AM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGf6d95a01103a: elftcl: add -i flag to ignore unknown flags.
emaste added a commit: rG369a4023e671: elftcl: add -i flag to ignore unknown flags.Jan 19 2021, 2:50 AM

Revision Contents
Changeset List

PathSize
usr.bin/
elfctl/
6 lines
13 lines

Diff 82189

View Options

usr.bin/elfctl/elfctl.1

Loading...
View Options

usr.bin/elfctl/elfctl.c

Loading...