diff: honour flags with -q
ClosedPublic
Actions

Authored by emaste on Jan 9 2021, 4:25 PM.

Tags

None

Referenced Files

	F132237367: D28064.id.diff
	Wed, Oct 15, 2:02 AM

	Unknown Object (File)
	Sun, Oct 12, 11:58 AM

	Unknown Object (File)
	Sun, Oct 12, 11:58 AM

	Unknown Object (File)
	Sun, Oct 12, 11:58 AM

	Unknown Object (File)
	Sun, Oct 12, 11:58 AM

	Unknown Object (File)
	Sun, Oct 12, 12:59 AM

	Unknown Object (File)
	Thu, Oct 9, 5:51 AM

	Unknown Object (File)
	Tue, Oct 7, 5:27 AM

View All Files

Subscribers

None

Details

Reviewers

kevans
bapt

Commits

rG7366c22508e9: diff: honour flags with -q
rG12a8d3027d41: diff: honour flags with -q

Summary

Previously -q (just print a line when files differ) ignored flags like -w (ignore whitespace). Avoid the D_BRIEF short-circuit when flags are in effect.

PR: 252515

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Jan 9 2021, 4:25 PM

emaste created this revision.

add test

kevans accepted this revision.Jan 9 2021, 6:29 PM

This revision is now accepted and ready to land.Jan 9 2021, 6:29 PM

Closed by commit rG12a8d3027d41: diff: honour flags with -q (authored by emaste). · Explain WhyJan 9 2021, 6:35 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG12a8d3027d41: diff: honour flags with -q.

emaste added a commit: rG7366c22508e9: diff: honour flags with -q.Jan 15 2021, 2:27 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

diff/

diffreg.c

4 lines

tests/

diff_test.sh

10 lines

Diff 81963

View Options

usr.bin/diff/diffreg.c