Add KASSERTS to nfsm_trimtrailing() to confirm the sanity of
the arguments for the M_EXTPG case.
Kostik, is this what you were suggesting?
Differential D28053
add kasserts to nfsm_trimtrailing as suggested by kib@ rmacklem on Jan 9 2021, 12:20 AM. Authored by Tags None Referenced Files
Subscribers None
Details Add KASSERTS to nfsm_trimtrailing() to confirm the sanity of Kostik, is this what you were suggesting? Set ND_EXTPG flag for all NFS RPCs so the the case
Diff Detail
Event TimelineComment Actions Yes, intent was to re-check that bpos points to the same position as bextpg with bextpgsiz. But I see (PAGE_SIZE - bextpgsiz) and now see that my understanding was wrong. Please note that PHYS_TO_DMAP() is not available on all platforms, other code does #ifdef PHYS_TO_DMAP around code that only makes sense on machines with DMAP. Comment Actions Yes, bextpgsiz is the bytes remaining to be used in the page. Actually PHYS_TO_DMAP() is defined for all arches, support DMAP and that is the only time the NFS code generates M_EXTPG pages. --> Should be ok. |