Page MenuHomeFreeBSD

sysutils/nix: Update to 2.3.10
ClosedPublic

Authored by nc on Jan 6 2021, 4:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 5:21 PM
Unknown Object (File)
Thu, Nov 7, 8:40 AM
Unknown Object (File)
Sun, Nov 3, 2:45 AM
Unknown Object (File)
Tue, Oct 22, 3:31 AM
Unknown Object (File)
Sun, Oct 20, 4:36 PM
Unknown Object (File)
Sun, Oct 20, 4:36 PM
Unknown Object (File)
Sun, Oct 20, 4:36 PM
Unknown Object (File)
Thu, Oct 17, 8:49 PM
Subscribers

Details

Summary

sysutils/nix: Update to 2.3.10

Test Plan

Passes poudriere on amd64 and i386.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nc requested review of this revision.Jan 6 2021, 4:23 AM

Since you (@0mp) are both the maintainer of this sysutils/nix and my mentor, I'm thinking about a commit message like:

sysutils/nix: Update to 2.3.10

PR:                    251897
Reviewed by:           0mp (mentor)
Approved by:           0mp (mentor, maintainer)

is this okay? Should the "Reviewed By" line say "0mp (mentor, maintainer)"?

Thanks for the patch.

BTW, if there is a Bugzilla PR associated with the patch, it's a good idea to link to that PR in the description.

In D27996#625236, @nc wrote:

Since you (@0mp) are both the maintainer of this sysutils/nix and my mentor, I'm thinking about a commit message like:

sysutils/nix: Update to 2.3.10

PR:                    251897
Reviewed by:           0mp (mentor)
Approved by:           0mp (mentor, maintainer)

is this okay? Should the "Reviewed By" line say "0mp (mentor, maintainer)"?

I'd say:

Reviewed by:           0mp
Approved by:           0mp (mentor, maintainer)

because the role/hat is not important in case of "Reviewed by".

When it comes to the patch itself, I am surprised that it works. Last time I worked on Nix I had to change a lot of things (WIP repo is here: https://github.com/0mp/freebsd-ports-nix).

Like, for example, I know that there is a new dependency to build manual pages called mdbook. So I am surprised it is not in the patch you submitted.

I'll try to build 2.3.10 now and run the test suite and let you know how I would like to proceed.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 7 2021, 10:37 AM
Closed by commit rP560702: Update to 2.3.10 (authored by 0mp). · Explain Why
This revision was automatically updated to reflect the committed changes.

It worked. That's very interesting... Anyway, thanks for the patch!