Page MenuHomeFreeBSD

games/automuteus: Update to 6.8.0
ClosedPublic

Authored by nc on Jan 5 2021, 3:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 11:37 PM
Unknown Object (File)
Sun, Apr 21, 7:38 PM
Unknown Object (File)
Feb 19 2024, 2:38 PM
Unknown Object (File)
Feb 19 2024, 2:38 PM
Unknown Object (File)
Feb 19 2024, 2:38 PM
Unknown Object (File)
Feb 19 2024, 2:37 PM
Unknown Object (File)
Feb 19 2024, 7:45 AM
Unknown Object (File)
Dec 20 2023, 4:54 AM
Subscribers

Details

Summary

games/automuteus: Update to 6.8.0

ChangeLog: https://github.com/denverquane/automuteus/releases/tag/6.7.2

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nc requested review of this revision.Jan 5 2021, 3:42 PM

Two questions:

  1. Are there any release notes maybe for this software? If they are interesting enough, it might be a good idea to include a link in the commit message.
  2. How did you test it? The patch seems fine, I just would like to know what kind of tests did you run to make sure it does not break after being committed.

For release notes, I have them here: https://github.com/denverquane/automuteus/releases/tag/6.7.2

Since the "gaming PC" I have is actually my Ports development box, I tested the port by making sure unit tests pass.

There is now a 6.8.0, I will update this diff with 6.8.0.

nc retitled this revision from games/automuteus: Update to 6.7.2 to games/automuteus: Update to 6.8.0.Jan 5 2021, 4:45 PM
nc edited the summary of this revision. (Show Details)
In D27975#624858, @nc wrote:

For release notes, I have them here: https://github.com/denverquane/automuteus/releases/tag/6.7.2

Since the "gaming PC" I have is actually my Ports development box, I tested the port by making sure unit tests pass.

  1. If you were able to run unit tests you might want to add a test target to the port (unless USES=go already provides some defaults, I am not sure). That's optional, but encouraged.
  2. Unless you know that the port is going to build for sure across all supported releases and architectures (currently i386 and amd64) it's good to see if the port builds in poudriere. This way you can be sure (in most cases) that the update won't cause a pkg fallout. I try to test updates in poudriere in at least one release-architecture configuration for simple ports. Let me know if you'd like any suggestions about how to set everything up. The bottom line is that I'd feel much more comfortable approving patches if you test them in poudriere or provide an explanation why it is not necessary to waste cycles in a particular case.

automuteus does build on i386. I believe Go should have some defaults also.

I could also make the automuteus binary run on amd64 (12.2-RELEASE and 13-CURRENT).

This revision is now accepted and ready to land.Jan 5 2021, 11:01 PM
This revision was automatically updated to reflect the committed changes.