Page MenuHomeFreeBSD

sbin/sysctl: Always honor skip in sysctl_all
ClosedPublic

Authored by freqlabs on Dec 18 2020, 8:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 23, 9:57 PM
Unknown Object (File)
Sun, Mar 22, 11:41 PM
Unknown Object (File)
Wed, Mar 18, 3:48 AM
Unknown Object (File)
Wed, Mar 18, 3:06 AM
Unknown Object (File)
Sun, Mar 15, 7:47 AM
Unknown Object (File)
Fri, Mar 13, 3:38 PM
Unknown Object (File)
Fri, Mar 13, 7:43 AM
Unknown Object (File)
Fri, Mar 13, 2:31 AM
Subscribers

Details

Summary

Fix broken CTLFLAG_SKIP when present on the first child of the requested node.

We don't need to ignore skip for the first node because in sysctl_all() we've implicitly visited the first node already when oid is specified. The first call to show_var() in here is after we have iterated to the next node. When the command line specifically requests a non-node sysctl we go straight into show_var() without calling sysctl_all().

Reported by: jhb
Sponsored by: iXsystems, Inc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped