Page MenuHomeFreeBSD

sbin/sysctl: Always honor skip in sysctl_all
ClosedPublic

Authored by freqlabs on Dec 18 2020, 8:45 PM.
Tags
None
Referenced Files
F156713748: D27674.id80913.diff
Fri, May 15, 8:40 PM
F156713715: D27674.id80913.diff
Fri, May 15, 8:39 PM
F156713166: D27674.diff
Fri, May 15, 8:35 PM
Unknown Object (File)
Tue, Apr 28, 1:55 AM
Unknown Object (File)
Thu, Apr 16, 1:31 PM
Unknown Object (File)
Apr 4 2026, 8:28 AM
Unknown Object (File)
Apr 2 2026, 6:44 AM
Unknown Object (File)
Apr 1 2026, 2:20 AM
Subscribers

Details

Summary

Fix broken CTLFLAG_SKIP when present on the first child of the requested node.

We don't need to ignore skip for the first node because in sysctl_all() we've implicitly visited the first node already when oid is specified. The first call to show_var() in here is after we have iterated to the next node. When the command line specifically requests a non-node sysctl we go straight into show_var() without calling sysctl_all().

Reported by: jhb
Sponsored by: iXsystems, Inc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped