Page MenuHomeFreeBSD
Differential D27582

Use __containerof() instead of home-rolled versions.
ClosedPublic
Actions

Authored by jhb on Dec 11 2020, 9:26 PM.
Tags
None
Referenced Files
F136195718: D27582.diff
Sun, Nov 16, 2:59 PM
Unknown Object (File)
Fri, Nov 14, 12:40 PM
Unknown Object (File)
Sun, Nov 9, 5:48 AM
Unknown Object (File)
Sat, Nov 1, 8:19 AM
Unknown Object (File)
Sat, Oct 25, 5:47 PM
Unknown Object (File)
Sat, Oct 25, 5:43 PM
Unknown Object (File)
Sat, Oct 25, 3:59 PM
Unknown Object (File)
Sat, Oct 18, 8:23 PM
View All 96 Files
Subscribers
imp

Details

Reviewers
imp
• hselasky
Commits
rS368741: Use __containerof() instead of home-rolled versions.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Dec 11 2020, 9:26 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 11 2020, 9:26 PM
jhb requested review of this revision.Dec 11 2020, 9:26 PM
Harbormaster completed remote builds in B35362: Diff 80611.Dec 11 2020, 9:26 PM
imp accepted this revision.Dec 11 2020, 10:29 PM

Might need to make sure stand/usb doesn't need __container_of() defined. It's not built by default.

This revision is now accepted and ready to land.Dec 11 2020, 10:29 PM
jhb added a reviewer: • hselasky.Dec 12 2020, 4:53 PM
• hselasky accepted this revision.Dec 12 2020, 7:53 PM

Just make sure stand/usb builds after this change too.

cd stand/usb
make all

That's it.

sys/dev/usb/controller/uhci.c
86 ↗(On Diff #80611)

There is no need for parenthesis around (bus). Macro arguments are already separated by comma!

Ditto for the other places too.

jhb added a comment.Dec 16 2020, 12:25 AM

stand/usb builds ok for both this and the previous review.

sys/dev/usb/controller/uhci.c
86 ↗(On Diff #80611)

It is FreeBSD's style to always add parens around macro arguments in the macro's expansion.

jhb marked an inline comment as done.Dec 17 2020, 8:40 PM
jhb added inline comments.
sys/dev/usb/controller/uhci.c
86 ↗(On Diff #80611)

OTOH, it the lack of ()'s does seem consistent in these files.

Closed by commit rS368741: Use __containerof() instead of home-rolled versions. (authored by jhb). · Explain WhyDec 17 2020, 8:45 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rS368741: Use __containerof() instead of home-rolled versions..

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
usb/
controller/
3 lines
3 lines
3 lines
3 lines
4 lines

Diff 80860

View Options

head/sys/dev/usb/controller/ehci.c

Loading...
View Options

head/sys/dev/usb/controller/ohci.c

Loading...
View Options

head/sys/dev/usb/controller/uhci.c

Loading...
View Options

head/sys/dev/usb/controller/xhci.c

Loading...
View Options

head/sys/dev/usb/usb_transfer.h

Loading...