Details
Details
- Reviewers
imp • hselasky - Commits
- rS368741: Use __containerof() instead of home-rolled versions.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Might need to make sure stand/usb doesn't need __container_of() defined. It's not built by default.
Comment Actions
Just make sure stand/usb builds after this change too.
cd stand/usb
make all
That's it.
| sys/dev/usb/controller/uhci.c | ||
|---|---|---|
| 86 ↗ | (On Diff #80611) | There is no need for parenthesis around (bus). Macro arguments are already separated by comma! Ditto for the other places too. |
Comment Actions
stand/usb builds ok for both this and the previous review.
| sys/dev/usb/controller/uhci.c | ||
|---|---|---|
| 86 ↗ | (On Diff #80611) | It is FreeBSD's style to always add parens around macro arguments in the macro's expansion. |
| sys/dev/usb/controller/uhci.c | ||
|---|---|---|
| 86 ↗ | (On Diff #80611) | OTOH, it the lack of ()'s does seem consistent in these files. |