clang: allow -fstack-clash-protection on FreeBSD
ClosedPublic
Actions

Authored by emaste on Nov 25 2020, 1:03 AM.

Details

Reviewers

Commits

rGc37c3d580eb3: clang: allow -fstack-clash-protection on FreeBSD
rS368019: clang: allow -fstack-clash-protection on FreeBSD

Summary

-fstack-clash-protection was added in Clang commit e67cbac81211 but was enabled only on Linux. It should work fine on FreeBSD too so enable it.

To be upstreamed, with a corresponding test suite change.

Relnotes: Yes
MFC after: 3 days

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Nov 25 2020, 1:03 AM

emaste created this revision.

LLVM change that introduced support: https://reviews.llvm.org/D68720

Yeah, that seems perfectly OK to me.

This revision is now accepted and ready to land.Nov 25 2020, 12:58 PM

Closed by commit rS368019: clang: allow -fstack-clash-protection on FreeBSD (authored by emaste). · Explain WhyNov 25 2020, 2:26 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rS368019: clang: allow -fstack-clash-protection on FreeBSD.

Herald added a subscriber: imp. · View Herald TranscriptNov 25 2020, 2:26 PM

Upstream review https://reviews.llvm.org/D108571

dim added a commit: rGc37c3d580eb3: clang: allow -fstack-clash-protection on FreeBSD.Dec 22 2021, 10:09 AM

Revision Contents
Changeset List

Path

Size

head/

contrib/

llvm-project/

clang/

lib/

Driver/

ToolChains/

Clang.cpp

2 lines

Diff 79989

View Options

head/contrib/llvm-project/clang/lib/Driver/ToolChains/Clang.cpp

clang: allow -fstack-clash-protection on FreeBSDClosedPublicActions