Page MenuHomeFreeBSD

uma: Avoid allocating buckets with the cross-domain lock held
ClosedPublic

Authored by markj on Nov 23 2020, 2:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 6, 6:50 AM
Unknown Object (File)
Thu, Sep 25, 12:49 AM
Unknown Object (File)
Fri, Sep 12, 8:07 PM
Unknown Object (File)
Sep 11 2025, 2:29 AM
Unknown Object (File)
Sep 10 2025, 7:28 PM
Unknown Object (File)
Sep 10 2025, 6:41 PM
Unknown Object (File)
Sep 10 2025, 5:27 PM
Unknown Object (File)
Sep 10 2025, 5:11 PM
Subscribers

Details

Summary

Allocation of a bucket can trigger a cross-domain free in the bucket
zone, e.g., if the per-CPU alloc bucket is empty, we free it and get
migrated to a remote domain. I believe this can lead to deadlocks,
since a bucket zone may allocate buckets from itself, or a pair of
bucket zones could be allocating from each other.

Fix the problem by dropping the cross-domain lock before allocating a
new bucket and handling refill races. I added a list of empty buckets
to ensure that we can make forward progress.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Nov 23 2020, 2:33 PM
markj created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2020, 4:19 PM
This revision was automatically updated to reflect the committed changes.