Page MenuHomeFreeBSD

Fix double unlock if the source file disappears
ClosedPublic

Authored by trasz on Nov 23 2020, 1:58 PM.

Details

Summary

Fix double unlock if the source file disappears; we would
unlock it here, only to unlock it again below, just before "bad".

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

trasz requested review of this revision.Nov 23 2020, 1:58 PM
sys/fs/msdosfs/msdosfs_vnops.c
1144

So why this vrele() uses a_vfp pointer instead of fvp ? Is it possible that they are different (doubt it). If so wouldn't it be more natural to stop these intermediate vrele/unlocks, replacing them by final vput(fvp) ?

sys/fs/msdosfs/msdosfs_vnops.c
1144

It is possible they are different - this code happens after a call to relookup(), which can change fvp. In fact, it has to be different, given the conditional ("xp != ip").

This revision is now accepted and ready to land.Dec 3 2020, 1:14 PM