Differential D27336

Make bsnmpclient(3) thread-safe
AbandonedPublic
Actions

Authored by trasz on Nov 23 2020, 1:46 PM.

Tags

None

Referenced Files

	F154330285: D27336.id.diff
	Mon, Apr 27, 9:36 PM

	F154266047: D27336.id.diff
	Mon, Apr 27, 11:58 AM

	Unknown Object (File)
	Sat, Apr 25, 1:02 PM

	Unknown Object (File)
	Fri, Apr 24, 10:23 PM

	Unknown Object (File)
	Tue, Apr 21, 11:14 PM

	Unknown Object (File)
	Sun, Apr 19, 5:41 PM

	Unknown Object (File)
	Sun, Apr 19, 5:40 PM

	Unknown Object (File)
	Sun, Apr 12, 3:19 PM

Subscribers

Details

Reviewers

Commits

rG89e3d5671ba1: bsnmpclient(3): make it thread-safe

Summary

Make bsnmpclient(3) thread-safe.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Nov 23 2020, 1:46 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 23 2020, 1:46 PM

trasz requested review of this revision.Nov 23 2020, 1:46 PM

Harbormaster completed remote builds in B34978: Diff 79895.Nov 23 2020, 1:46 PM

trasz added a reviewer: harti.Nov 23 2020, 1:47 PM

trasz added a subscriber: NetApp.

(Tinderboxed.)

For me this looks good. In the middle term (next year) I have a plan to get rid of static data in the library.

This revision is now accepted and ready to land.Nov 24 2020, 11:12 AM

Closed by commit rG89e3d5671ba1: bsnmpclient(3): make it thread-safe (authored by trasz). · Explain WhyDec 29 2020, 3:01 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rG89e3d5671ba1: bsnmpclient(3): make it thread-safe.

trasz added a reverting change: rGf53120073b32: Revert "bsnmpclient(3): make it thread-safe".Dec 29 2020, 7:59 PM

... And reverted in f53120073b3 - mostly because, as Jessica pointed out, it would break existing applications which properly share the context between threads, eg by using explicit locking.

allanjude reopened this revision.Mar 2 2021, 11:08 PM

trasz abandoned this revision.Dec 29 2021, 9:06 PM

Revision Contents
Changeset List

Path

Size

contrib/

bsnmp/

lib/

2 lines

2 lines

4 lines

Diff 81296

contrib/bsnmp/lib/asn1.c

Loading...

contrib/bsnmp/lib/snmpclient.h

Loading...

contrib/bsnmp/lib/snmpclient.c

Loading...