Page MenuHomeFreeBSD

Revert r367291 (KEYWORD: shutdown for rc.d/zfs)
ClosedPublic

Authored by 0mp on Nov 18 2020, 8:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 23 2024, 5:52 PM
Unknown Object (File)
Feb 23 2024, 5:52 PM
Unknown Object (File)
Feb 23 2024, 5:52 PM
Unknown Object (File)
Feb 23 2024, 5:33 PM
Unknown Object (File)
Feb 22 2024, 12:32 PM
Unknown Object (File)
Feb 4 2024, 3:51 AM
Unknown Object (File)
Jan 8 2024, 1:24 PM
Unknown Object (File)
Dec 26 2023, 4:14 PM
Subscribers

Details

Summary
Revert r367291 (KEYWORD: shutdown for rc.d/zfs)

The problem is that zfs is asked to stop too early in the shutdown
sequence. Other services, such as syslog may still be running and have some
files open (e.g., under /var/log). This of course causes the messages like:

  cannot unmount '/var/run': umount failed
  cannot unmount '/var/log': umount failed
  cannot unmount '/var': umount failed
  cannot unmount '/usr/home': umount failed
  cannot unmount '/usr': umount failed
  cannot unmount '/': umount failed

For now, let's remove the shutdown KEYWORD from the zfs service, as people are
reporting problems in their setups:
https://lists.freebsd.org/pipermail/freebsd-current/2020-November/077559.html

In the future, we may think of stopping zfs on shutdown after all the other
services and just before init(8) exits. Another interesting option might be to
a new rcorder(8) KEYWORD like "shutdownjail", but this idea would need to be
discussed a bit.

Reported by:	Johan Hendriks <joh.hendriks gmail.com>
Reported by:	Yasuhiro KIMURA <yasu utahime.org>
Reported by: Tomoaki AOKI <junchoon dec.sakura.ne.jp>
MFC:		3 days

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp requested review of this revision.Nov 18 2020, 8:38 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 20 2020, 2:37 PM
This revision was automatically updated to reflect the committed changes.