bug fix: iommu_gas_fini_domain()
ClosedPublic
Actions

Authored by br on Nov 16 2020, 11:37 AM.

Tags

None

Referenced Files

	F132383604: D27235.id79595.diff
	Thu, Oct 16, 10:41 AM

	Unknown Object (File)
	Wed, Oct 8, 10:22 PM

	Unknown Object (File)
	Fri, Sep 19, 10:26 PM

	Unknown Object (File)
	Sep 11 2025, 8:55 AM

	Unknown Object (File)
	Aug 16 2025, 1:41 AM

	Unknown Object (File)
	Jul 25 2025, 8:26 PM

	Unknown Object (File)
	Jul 1 2025, 10:59 AM

	Unknown Object (File)
	Jun 29 2025, 3:51 PM

View All 70 Files

Subscribers

imp

Details

Reviewers

kib

Commits

rS367726: Fix a bug in assertion: entry flags also includes IOMMU_MAP_ENTRY_UNMAPPED.

Summary

iommu_gas_init_domain() sets these two flags, so check them both in iommu_gas_fini_domain()

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

br requested review of this revision.Nov 16 2020, 11:37 AM

br created this revision.

kib added inline comments.Nov 16 2020, 12:28 PM

sys/dev/iommu/iommu_gas.c
262 ↗	(On Diff #79595)	Indent for continuation line should be +4 spaces, not tab. () are not needed.

Fix indentation

sys/dev/iommu/iommu_gas.c
262 ↗	(On Diff #79595)	() are needed it seems: sys/dev/iommu/iommu_gas.c:262:28: error: \| has lower precedence than ==; == will be evaluated first [-Werror,-Wparentheses] IOMMU_MAP_ENTRY_PLACE \| IOMMU_MAP_ENTRY_UNMAPPED,

kib accepted this revision.Nov 16 2020, 12:42 PM

This revision is now accepted and ready to land.Nov 16 2020, 12:42 PM

Closed by commit rS367726: Fix a bug in assertion: entry flags also includes IOMMU_MAP_ENTRY_UNMAPPED. (authored by br). · Explain WhyNov 16 2020, 3:37 PM

This revision was automatically updated to reflect the committed changes.

br added a commit: rS367726: Fix a bug in assertion: entry flags also includes IOMMU_MAP_ENTRY_UNMAPPED..

Herald added a subscriber: imp. · View Herald TranscriptNov 16 2020, 3:37 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

iommu/

iommu_gas.c

6 lines

Diff 79608

View Options

head/sys/dev/iommu/iommu_gas.c

bug fix: iommu_gas_fini_domain()ClosedPublicActions