Page MenuHomeFreeBSD

bug fix: iommu_gas_fini_domain()
ClosedPublic

Authored by br on Mon, Nov 16, 11:37 AM.

Details

Summary

iommu_gas_init_domain() sets these two flags, so check them both in iommu_gas_fini_domain()

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

br requested review of this revision.Mon, Nov 16, 11:37 AM
br created this revision.
sys/dev/iommu/iommu_gas.c
262 ↗(On Diff #79595)

Indent for continuation line should be +4 spaces, not tab. () are not needed.

Fix indentation

sys/dev/iommu/iommu_gas.c
262 ↗(On Diff #79595)

() are needed it seems:

sys/dev/iommu/iommu_gas.c:262:28: error: | has lower precedence than ==; == will be evaluated first [-Werror,-Wparentheses]

IOMMU_MAP_ENTRY_PLACE | IOMMU_MAP_ENTRY_UNMAPPED,
This revision is now accepted and ready to land.Mon, Nov 16, 12:42 PM