Page MenuHomeFreeBSD

Move Xen Kernel menuitem to Boot Options submenu.
ClosedPublic

Authored by dteske on Jun 3 2015, 12:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 24, 6:06 PM
Unknown Object (File)
Sat, Dec 7, 12:50 PM
Unknown Object (File)
Sun, Dec 1, 2:20 PM
Unknown Object (File)
Nov 26 2024, 7:55 AM
Unknown Object (File)
Nov 25 2024, 2:13 PM
Unknown Object (File)
Nov 24 2024, 9:37 PM
Unknown Object (File)
Nov 24 2024, 11:07 AM
Unknown Object (File)
Nov 24 2024, 3:11 AM
Subscribers
None

Details

Summary

Move Xen Kernel menuitem to Boot Options submenu. Prevent conflict with
upcoming Boot Environment menu. The Xen Kernel is dynamically appended
after the last menuitem in the Boot Options submenu. If xen_kernel is not
defined in loader.conf(5) the Xen Kernel menuitem displays "N/A" versus
"On"/"off". While here, fix-up the pkg-message (make capitalization of
"in" vs. "In" consistent; make use of trailing ":" consistent; move a
comment out of the way of file contents, etc.).

Test Plan

NB: Requires 11.0-CURRENT@r277215 or later.

  1. Install emulators/xen-kernel
  2. Do the prescribed steps in pkg-message
  3. Reboot
  4. If your system has VT-d CPUID capability, xen_kernel will be loaded and the machine will boot. sysctl kern.bootfile shows the Xen kernel otherwise the Xen kernel will kernel panic.
  5. Reboot and this time go into the Boot Options submenu and toggle Xen Kernel to "off" and press Enter to boot. sysctl kern.bootfile shows the normal FreeBSD kernel.
  6. If as-described above, the toggle is working as expected.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dteske retitled this revision from to Move Xen Kernel menuitem to Boot Options submenu..
dteske updated this object.
dteske edited the test plan for this revision. (Show Details)
dteske added reviewers: allanjude, bapt.

Oops; this is the working code

allanjude edited edge metadata.

Tested for the following cases:

default case: boots xen
o, x, 1, 1 (toggle xen off) boots without xen
o, x, x, 1, 1 (toggle xen off, and back on) boots xen
o, x, x, x, 1, 1 (toggle xen off, on, and back off), boots without xen

boot with xen_kernel not set: menu item says N/A
toggle xen option when N/A: no op

using menu item 5 to switch to kernel.old, with xen still active. loads xen then loads kernel.old as expected

This revision is now accepted and ready to land.Jun 3 2015, 3:04 AM

We should probably include in the diff a bump to PORTREVISION in Makefile.

dteske edited edge metadata.

Add PORTREVISION bump in Makefile

This revision now requires review to proceed.Jun 3 2015, 4:32 AM
This revision is now accepted and ready to land.Jun 3 2015, 4:34 AM
dteske edited the test plan for this revision. (Show Details)
dteske edited edge metadata.

Can one upload the diff again so that I can look at it? recent changes on phabricator lost some diffs including that one :(

dteske edited edge metadata.

Reup the diff

This revision now requires review to proceed.Jun 24 2015, 1:38 AM
bapt edited edge metadata.
This revision is now accepted and ready to land.Jun 24 2015, 5:36 AM
This revision was automatically updated to reflect the committed changes.