Page MenuHomeFreeBSD

When destroying a UMA zone with a reserve, properly drain kegs
ClosedPublic

Authored by jtl on Nov 6 2020, 9:18 PM.

Details

Summary

When destroying a UMA zone which has a reserve (set with uma_zone_reserve()), messages like the following appear on the console:

Freed UMA keg (Test zone) was not empty (0 items). Lost 528 pages of memory.

When keg_drain_domain() is draining the zone, it tries to keep the number of items specified in the reservation. However, when we are destroying the UMA zone, we do not need to keep those items. Therefore, when destroying a non-secondary and non-cache zone, we should reset the keg reservation to 0 prior to draining the zone.

Test Plan

The following sequence produces the error message before the change, and does not after the change:

testzone = uma_zcreate("Test zone", 33 * 4096, NULL, NULL, NULL, NULL, UMA_ALIGN_PTR, 0);
uma_zone_reserve(testzone, 16);
uma_prealloc(testzone, 16);
uma_zdestroy(testzone);

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.