Sync libcxxrt demangler with libelftc plus fixes
Needs ReviewPublic
Actions

Authored by dim on Nov 2 2020, 6:30 PM.

Details

Reviewers

emaste
yuri

Summary

This updates the private copy of libelftc_dem_gnu3.c in libcxxrt with
the most recent version from upstream r3806. I also added all the fixes
from D27058.

We should really have some way of either automatically updating this
file from libelftc, or make it use the libelftc .c files directly, but
for now this will do.

Test Plan

Same as for D27058, but using this small test program:

#include <cxxabi.h>
#include <stdio.h>
#include <stdlib.h>

static void demangle(const char *mangled_name)
{
  int status;
  char *demangled_name = abi::__cxa_demangle(mangled_name, NULL, NULL, &status);
  switch (status) {
  case 0:
    printf("%s -> %s\n", mangled_name, demangled_name);
    break;
  case -1:
    printf("error: memory allocation failure while demangling %s\n", mangled_name);
    break;
  case -2:
    printf("error: %s is not a valid C++ mangled name\n", mangled_name);
    break;
  case -3:
    printf("error: invalid argument(s) while demangling %s\n", mangled_name);
    break;
  default:
    printf("error: unknown status %d while demangling %s\n", status, mangled_name);
    break;
  }
  free(demangled_name);
}

int main(int argc, char *argv[])
{
  if (argc <= 1) {
    printf("Usage: %s mangled_name ...\n", argv[0]);
    return 1;
  }
  for (int i = 1; i < argc; ++i) {
    demangle(argv[i]);
  }
  return 0;
}