Since the 2.1.17 release the build system has been significantly revised and contains many changes that had to be adapted to the Ports framework. One of the biggest changes is that Anki now also uses a Rust library that is used by the Python code. Changelog since 2.1.16 (too many changes to list them separately): https://changes.ankiweb.net/ PR: 247666 Reported by: David Schlachter
Details
Details
- Reviewers
tcberner - Group Reviewers
rust Python - Commits
- rP554834: games/anki: Update to 2.1.35
- poudriere -> OK (11.4-, 12.1-RELEASE, 13.0-CURRENT@r366935 [amd64 only])
- Runtime tests -> OK (12.1-RELEASE amd64)
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
- Restore dependency of audio/lame
- Place new dependencies in RUN_DEPENDS to the end so that they're more visible in the diff.
Comment Actions
Rust ports are "beautiful" :P
Im not sure whether it is a good idea to execute all the commands silenty during build -- I would probably prefer to remove the '@'.
But other than that I spot no issues.
Comment Actions
Good catch, thank you for the pointer and the review!
Indeed, those commands shouldn't be silenced. Hence I'll remove the @'s from the {pre,post}-build targets and do the same for D26960 as well, before I commit both diffs in the next few days.
Comment Actions
During further QA it became apparent that building the Rust library via the pre-build target isn't necessary at all. The real work is solely done via devel/py-maturin which acts as a wrapper for cargo + rustc and adds Python bindings to the binary file at the end.
The updated diff contains following changes
- Additional entries for ${MAKE_ENV} and ${MAKE_ARGS} to pass Rust related parameters to maturin to make it more verbose and to honor the flags from the Ports framework.
- build/install related commands are now verbose as suggested by @tcberner
- Updated comments