Page MenuHomeFreeBSD

[Mk/Scripts/qa.sh] add more file to the exclusion list of path check
AbandonedPublic

Authored by sunpoet on May 31 2015, 3:19 PM.

Details

Reviewers
None
Group Reviewers
portmgr
Summary

Some ruby gems would install build logs which contain STAGEDIR.
Since these files are harmless, I propose to add them to the exclusion list of STAGEDIR-prefixed path check.

Test Plan

Build devel/rubygem-fastthread (rubygem-fastthread-1.0.7.txz).

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

sunpoet updated this revision to Diff 5838.May 31 2015, 3:19 PM
sunpoet retitled this revision from to [Mk/Scripts/qa.sh] add more file to the exclusion list of path check.
sunpoet updated this object.
sunpoet edited the test plan for this revision. (Show Details)
swills added a subscriber: swills.Jul 21 2015, 1:24 PM

Personally, I whitelist */lib/ruby/gems/* locally.

bapt added a subscriber: bapt.Jul 21 2015, 1:29 PM
In D2693#62573, @swills wrote:

Personally, I whitelist */lib/ruby/gems/* locally.

Which is imho probably a bad idea, there might be content in this place which needs to be checked properly (given some path could get hardcoded.

I really wonder why in the first place we do install those files if they are not useful?

bapt added a comment.Jul 21 2015, 1:30 PM

ah and other question what is done on other packaging system about those?

I think we should have Mk/bsd.ruby.mk or in the future Mk/Uses/ruby.mk delete these. We need to muck with ffi/c extentions anyway since they violdate stagedir and builf outside of the build phase.

There is already a bugzilla on that one.

swills added a comment.EditedJul 24 2015, 2:31 PM

See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192949 for a patch which may make this change to qa.sh unnecessary. It at least solves some of the problem of packaging stuff that we don't need in gem packages. It doesn't solve the issue of building occurring in stage phase and there will still be some stuff we don't need, but it's a start.

sunpoet abandoned this revision.Dec 29 2016, 6:12 PM