Save errno in `warn()` family of functions
ClosedPublic
Actions

Authored by otis on Oct 19 2020, 9:17 PM.

Details

Reviewers

imp

Commits

rS366982: warnx: Save errno across calls that might change it.

Summary

When warn() family of functions is being used after err_set_file() has been set to, for example, /dev/null, errno is being clobbered, rendering it unreliable after, for example, procstat_getpathname() when it is supposed to emit a warning. Then the errno is changed to Inappropriate ioctl for device, destroying the original value (via calls to fprintf()functions).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

otis created this revision.Oct 19 2020, 9:17 PM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptOct 19 2020, 9:17 PM

otis requested review of this revision.Oct 19 2020, 9:17 PM

I was going to ask why you didn't do this for the err* functions too... Then realized it was probably time for me to knock off for the day if I had that question :)

This revision is now accepted and ready to land.Oct 19 2020, 11:28 PM

In D26871#599219, @imp wrote:

I was going to ask why you didn't do this for the err* functions too... Then realized it was probably time for me to knock off for the day if I had that question :)