Differential D26824

Add plug and play information macroses for ACPI and I2C buses.
ClosedPublic
Actions

Authored by wulf on Oct 17 2020, 12:26 AM.

Details

Reviewers

imp

Commits

rS367677: MFC r367239-367241:
rS367239: Add plug and play information macroses for ACPI and I2C buses.

Summary

Matching table format is compatible with ACPI_ID_PROBE bus method used in most ACPI drivers.

Test Plan

ACPI part is tested with acpi_wmi(4) and acpi_dock(4) drivers. Required changes to these drivers are included.
IICBUS part is tested with development version of sysutils/iichid.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wulf requested review of this revision.Oct 17 2020, 12:26 AM

wulf created this revision.

val_packett.cool added a subscriber: val_packett.cool.Oct 17 2020, 12:11 PM

One nit on the comments, otherwise it's fine. Fix that and I'm good with what you commit (so I'm accepting it now). I'm a little worried about the DEV_ACPI ifdef, but it's likely fine... I suspect we'll have at least one module not built properly, or built independently of the tree that has issues, but we can look into those when that happens.

sys/dev/acpica/acpivar.h
236 ↗	(On Diff #78339)	You may wish to note that ACPI_ID_PROBE looks at both _HID and _CID, so both need to be listed. It took me a second to realize what you were doing here, and so I suspect others may need the hint as well.