Page MenuHomeFreeBSD
Differential D26816

Fix linprocfs(4) /proc/self/mem semantics
ClosedPublic
Actions

Authored by trasz on Oct 16 2020, 4:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 12, 4:03 PM
Unknown Object (File)
Wed, Aug 12, 12:23 AM
Unknown Object (File)
Mon, Aug 10, 8:06 PM
Unknown Object (File)
Mon, Aug 10, 4:50 PM
Unknown Object (File)
Sat, Aug 8, 9:46 PM
Unknown Object (File)
Sat, Aug 8, 6:31 PM
Unknown Object (File)
Sat, Aug 8, 8:27 AM
Unknown Object (File)
Fri, Aug 7, 8:50 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
Group Reviewers
Linux Emulation
Commits
rS366900: Fix linprocfs(4) /proc/self/mem semantics to more closely match Linux.
Summary

Fix linprocfs(4) /proc/self/mem semantics to more closely match Linux.
Steam's Anti-Cheat seems to use it.

PR: 248223

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz created this revision.Oct 16 2020, 4:04 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 16 2020, 4:04 PM
trasz requested review of this revision.Oct 16 2020, 4:04 PM
Harbormaster completed remote builds in B34213: Diff 78320.Oct 16 2020, 4:04 PM
trasz added a reviewer: Linux Emulation.Oct 16 2020, 4:32 PM
trasz added a comment.Oct 19 2020, 11:26 AM

(Tinderboxed).

trasz added a reviewer: kib.Oct 19 2020, 8:54 PM
kib added inline comments.Oct 19 2020, 10:17 PM
sys/compat/linprocfs/linprocfs.c
7 ↗(On Diff #78320)

Why ?

trasz added inline comments.Oct 19 2020, 10:33 PM
sys/compat/linprocfs/linprocfs.c
7 ↗(On Diff #78320)

It's there in sys/fs/procfs/procfs_mem.c, where I pasted the function from.

kib added inline comments.Oct 20 2020, 1:25 PM
sys/compat/linprocfs/linprocfs.c
7 ↗(On Diff #78320)

I do not think it is worth the hassle. Also, I do not see why don't you wrapped procfs_doprocmem.

trasz updated this revision to Diff 78504.Oct 20 2020, 2:11 PM

Reuse procfs_doprocmem() instead of copy/pasting it.

Harbormaster completed remote builds in B34282: Diff 78504.Oct 20 2020, 2:11 PM
trasz marked an inline comment as done.Oct 20 2020, 2:11 PM
kib accepted this revision.Oct 20 2020, 2:20 PM
kib added inline comments.
sys/compat/linprocfs/linprocfs.c
1289 ↗(On Diff #78504)

None of these blank lines is warranted or supported by style(9).

This revision is now accepted and ready to land.Oct 20 2020, 2:20 PM
Closed by commit rS366900: Fix linprocfs(4) /proc/self/mem semantics to more closely match Linux. (authored by trasz). · Explain WhyOct 20 2020, 5:24 PM
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rS366900: Fix linprocfs(4) /proc/self/mem semantics to more closely match Linux..
trasz added inline comments.Oct 20 2020, 5:24 PM
sys/compat/linprocfs/linprocfs.c
1289 ↗(On Diff #78504)

I find it easier to read this way, though.

kib added inline comments.Oct 20 2020, 11:27 PM
sys/compat/linprocfs/linprocfs.c
1289 ↗(On Diff #78504)

The only function of these blank lines is to eat vertical space in editor, allowing to see less code.

Revision Contents
Changeset List

PathSize
head/
sys/
compat/
linprocfs/
23 lines

Diff 78511

View Options

head/sys/compat/linprocfs/linprocfs.c

Loading...