Page MenuHomeFreeBSD
Differential D2671

Create the pypuppetdb port
ClosedPublic
Actions

Authored by allanjude on May 29 2015, 9:34 PM.
Tags
None
Referenced Files
F133491301: D2671.id5797.diff
Sun, Oct 26, 4:38 AM
Unknown Object (File)
Wed, Oct 22, 8:28 PM
Unknown Object (File)
Wed, Oct 22, 5:08 AM
Unknown Object (File)
Sat, Oct 18, 7:28 PM
Unknown Object (File)
Sat, Oct 18, 12:54 AM
Unknown Object (File)
Thu, Oct 16, 5:18 AM
Unknown Object (File)
Thu, Oct 16, 3:01 AM
Unknown Object (File)
Mon, Oct 13, 7:27 PM
View All Files
Subscribers
None

Details

Reviewers
xmj
Summary

This library is required by puppetboard

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

allanjude updated this revision to Diff 5787.May 29 2015, 9:34 PM
allanjude retitled this revision from to Create the pypuppetdb port This library is required by puppetboard.
allanjude updated this object.
allanjude edited the test plan for this revision. (Show Details)
allanjude added a reviewer: xmj.
xmj requested changes to this revision.May 30 2015, 2:48 AM
xmj edited edge metadata.

Please have a look at the output of portlint -AC.

databases/py-pypuppetdb/Makefile
6

PORTVERSION before DISTVERSIONPREFIX

11

USE_GITHUB and GH_ACCOUNT should come after LICENSE=

15

Comments shouldn't start with "a <foo>", and should start with a capital letter

17

Adding LICENSE_FILE is a good idea if it exists.

20

alphabetic ordering

This revision now requires changes to proceed.May 30 2015, 2:48 AM
xmj added a child revision: D2672: Create the puppetboard port.May 30 2015, 2:59 AM
allanjude updated this revision to Diff 5794.May 30 2015, 3:17 AM
allanjude edited edge metadata.
allanjude marked 5 inline comments as done.
allanjude retitled this revision from Create the pypuppetdb port This library is required by puppetboard to Create the pypuppetdb port.
allanjude updated this object.

fix portlint

allanjude updated this revision to Diff 5796.May 30 2015, 3:33 AM
allanjude edited edge metadata.

Add category Makefile

xmj added a comment.May 30 2015, 4:24 AM

Macro stampofapproval: lgtm shippit

xmj accepted this revision.May 30 2015, 4:25 AM
xmj edited edge metadata.
This revision is now accepted and ready to land.May 30 2015, 4:25 AM
allanjude updated this revision to Diff 5797.May 30 2015, 6:14 AM
allanjude edited edge metadata.

Fix config file

This revision now requires review to proceed.May 30 2015, 6:14 AM
xmj accepted this revision.Jun 1 2015, 4:08 PM
xmj edited edge metadata.

(still looking good.)

This revision is now accepted and ready to land.Jun 1 2015, 4:08 PM
allanjude closed this revision.Sep 6 2015, 5:49 PM

Revision Contents
Changeset List

PathSize
databases/
py-pypuppetdb/
21 lines
2 lines
4 lines

Diff 5794

View Options

databases/py-pypuppetdb/

Loading...
View Options

databases/py-pypuppetdb/Makefile

Loading...
View Options

databases/py-pypuppetdb/distinfo

Loading...
View Options

databases/py-pypuppetdb/pkg-descr

Loading...