Page MenuHomeFreeBSD

Create the pypuppetdb port
ClosedPublic

Authored by allanjude on May 29 2015, 9:34 PM.

Details

Reviewers
xmj
Summary

This library is required by puppetboard

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

allanjude retitled this revision from to Create the pypuppetdb port This library is required by puppetboard.
allanjude updated this object.
allanjude edited the test plan for this revision. (Show Details)
allanjude added a reviewer: xmj.
xmj requested changes to this revision.May 30 2015, 2:48 AM
xmj edited edge metadata.

Please have a look at the output of portlint -AC.

databases/py-pypuppetdb/Makefile
5

PORTVERSION before DISTVERSIONPREFIX

10

USE_GITHUB and GH_ACCOUNT should come after LICENSE=

14

Comments shouldn't start with "a <foo>", and should start with a capital letter

16

Adding LICENSE_FILE is a good idea if it exists.

19

alphabetic ordering

This revision now requires changes to proceed.May 30 2015, 2:48 AM
allanjude edited edge metadata.
allanjude marked 5 inline comments as done.
allanjude retitled this revision from Create the pypuppetdb port This library is required by puppetboard to Create the pypuppetdb port.
allanjude updated this object.

fix portlint

allanjude edited edge metadata.

Add category Makefile

xmj edited edge metadata.
This revision is now accepted and ready to land.May 30 2015, 4:25 AM
allanjude edited edge metadata.

Fix config file

This revision now requires review to proceed.May 30 2015, 6:14 AM
xmj edited edge metadata.

(still looking good.)

This revision is now accepted and ready to land.Jun 1 2015, 4:08 PM