Page MenuHomeFreeBSD

sfxge: do not use DEBUG_FLAGS to enable extra debug checks
ClosedPublic

Authored by arybchik on May 28 2015, 5:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 7, 1:57 PM
Unknown Object (File)
Wed, May 6, 10:59 AM
Unknown Object (File)
Wed, May 6, 5:34 AM
Unknown Object (File)
Sun, May 3, 10:01 AM
Unknown Object (File)
Wed, Apr 29, 2:29 PM
Unknown Object (File)
Wed, Apr 29, 2:25 PM
Unknown Object (File)
Sat, Apr 25, 3:23 PM
Unknown Object (File)
Fri, Apr 24, 11:10 PM
Subscribers

Details

Summary

DEBUG_FLAGS are set to DEBUG option value when kernel is built.
For example, it is -g in GENERIC config to have debug symbols.
Also DEBUG_FLAGS are used to determine if ctfconvert should keep
debug symbols.
Since we redefined DEBUG_FLAGS, debug symbols were always missing.
ctfconvert complains about it during kernel build.
It is incorrect to append DEBUG_FLAGS, since if DEBUG has no -g (or
similar), we'll have no debug symbols and ctfconvert will complain.
If it incorrect to always have -g in our DEBUG_FLAGS, since debug
symbols presence should be controllable by kernel config.
So, just add disabled by default addition of -DDEBUG=1 to CFLAGS.

Sponsored by: Solarflare Communications, Inc.
MFC after: 2 days

Test Plan

Kernel build tested. ctfconver does not log ERRORs which the patch applied.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arybchik retitled this revision from to sfxge: do not use DEBUG_FLAGS to enable extra debug checks.
arybchik updated this object.
arybchik edited the test plan for this revision. (Show Details)
arybchik added a reviewer: gnn.
imp added a reviewer: imp.
This revision is now accepted and ready to land.May 29 2015, 12:37 AM
This revision was automatically updated to reflect the committed changes.