Fix format specifies type 'int' but the arguemnt has type 'long'

[imp]

contrib/diff/src/context.c

65 ↗

(On Diff #5743)

This can't possibly be right. %j is the modifier for intmax_t.
You should have changed the second %.9d to %.9ld

[araujo]

Sorry for the noise and thanks to point it out.

[• rodrigc]

This fix is wrong. You will get warnings on i386, which we still support building on.
A better fix would be to do:

sprintf(buf, "%jd.%.9jd", (intmax_t)sec, (intmax_t)nsec);

[araujo]

Apply rodrigc@ suggestion.

[• rodrigc]

contrib/diff/src/context.c

65 ↗

(On Diff #5764)

OK, sorry to change my mind on this. I had to look at the code. In the function, we have:

long nsec ....
time_t sec ..........

I'm going to agree with @imp here.
I think this line should be

sprintf(buf, "%jd.%.9ld", (intmax_t)sec, nsec);

[araujo]

Rollback @imp first review.