Avoid a dubious assignment to bio_data in aio_qbio().
ClosedPublic
Actions

Authored by jhb on Sep 29 2020, 9:14 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Sep 27, 1:23 PM

	Unknown Object (File)
	Thu, Sep 17, 9:57 PM

	Unknown Object (File)
	Thu, Sep 17, 4:51 PM

	Unknown Object (File)
	Wed, Sep 16, 2:45 AM

	Unknown Object (File)
	Tue, Sep 15, 6:17 AM

	Unknown Object (File)
	Thu, Sep 10, 10:03 PM

	Unknown Object (File)
	Thu, Sep 10, 2:01 PM

	Unknown Object (File)
	Thu, Sep 10, 6:49 AM

View All Files

Subscribers

imp

Details

Reviewers

kib

Commits

rS366296: Avoid a dubious assignment to bio_data in aio_qbio().

Summary

A user pointer is not a suitable value for bio_data and the next block
of code always overwrites bio_data anyway. Just use cb->aio_buf
directly in the call to vm_fault_quick_hold_pages().

Test Plan

kyua test -k /usr/tests/sys/aio/Kyuafile

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Sep 29 2020, 9:14 PM

jhb created this revision.

Harbormaster completed remote builds in B33886: Diff 77652.Sep 29 2020, 9:14 PM

kib accepted this revision.Sep 30 2020, 3:22 AM

This revision is now accepted and ready to land.Sep 30 2020, 3:22 AM

Closed by commit rS366296: Avoid a dubious assignment to bio_data in aio_qbio(). (authored by jhb). · Explain WhySep 30 2020, 5:49 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS366296: Avoid a dubious assignment to bio_data in aio_qbio()..

Herald added a subscriber: imp. · View Herald TranscriptSep 30 2020, 5:49 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

vfs_aio.c

3 lines

Diff 77693

View Options

Avoid a dubious assignment to bio_data in aio_qbio().ClosedPublicActions