Tags

None

Referenced Files

	F106649259: D26573.diff
	Fri, Jan 3, 8:53 AM

	Unknown Object (File)
	Thu, Jan 2, 1:01 AM

	Unknown Object (File)
	Tue, Dec 31, 1:38 PM

	Unknown Object (File)
	Tue, Dec 10, 5:01 PM

	Unknown Object (File)
	Sun, Dec 8, 1:58 PM

	Unknown Object (File)
	Wed, Dec 4, 9:12 PM

	Unknown Object (File)
	Oct 26 2024, 12:11 PM

	Unknown Object (File)
	Oct 1 2024, 11:33 AM

View All 61 Files

Subscribers

kevans

Details

Reviewers

kevans

Commits

rS366228: Report the kernel console on the boot screen

Summary

Toggling is anticpated with the 'C' command, but that code isn't
written yet.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33858
Build 31071: arc lint + arc unit

Event Timeline

imp requested review of this revision.Sep 28 2020, 6:37 AM

imp created this revision.

Harbormaster completed remote builds in B33848: Diff 77586.Sep 28 2020, 6:37 AM

make toggle work

Harbormaster completed remote builds in B33849: Diff 77587.Sep 28 2020, 6:51 AM

kevans added a subscriber: kevans.Sep 28 2020, 1:51 PM

kevans added inline comments.

stand/lua/menu.lua
291	Minor nit; it's a little uglier, but this should be `color.highlight("C") .. "ons: " .. core.getConsoleName()` to highlight the key alias.

Fix kyle's issue

Note: the kernel bits for reporting this also leaked into this review.

Harbormaster completed remote builds in B33857: Diff 77599.Sep 28 2020, 3:57 PM

unleak the kenrel bits

Harbormaster completed remote builds in B33858: Diff 77600.Sep 28 2020, 3:57 PM

This seems to LGTM. =)

This revision is now accepted and ready to land.Sep 28 2020, 4:01 PM

Closed by commit rS366228: Report the kernel console on the boot screen (authored by imp). · Explain WhySep 28 2020, 4:19 PM

This revision was automatically updated to reflect the committed changes.

imp marked an inline comment as done.

imp added a commit: rS366228: Report the kernel console on the boot screen.

Silly mock-up of console reporting in the menu
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 77600

stand/lua/core.lua

stand/lua/menu.lua

Silly mock-up of console reporting in the menuClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 77600

stand/lua/core.lua

stand/lua/menu.lua

Silly mock-up of console reporting in the menu
ClosedPublic
Actions

Revision Contents
Changeset List