Page MenuHomeFreeBSD
Differential D26573

Silly mock-up of console reporting in the menu
ClosedPublic
Actions

Authored by imp on Sep 28 2020, 6:37 AM.
Tags
None
Referenced Files
F163204293: D26573.id77586.diff
Tue, Jul 21, 1:03 AM
F163195167: D26573.id77587.diff
Mon, Jul 20, 11:02 PM
Unknown Object (File)
Sat, Jul 18, 10:10 AM
Unknown Object (File)
Sat, Jul 18, 4:03 AM
Unknown Object (File)
Tue, Jul 7, 2:34 AM
Unknown Object (File)
Tue, Jul 7, 2:07 AM
Unknown Object (File)
Mon, Jul 6, 5:17 AM
Unknown Object (File)
Fri, Jul 3, 8:04 AM
View All Files
Subscribers
kevans

Details

Reviewers
kevans
Commits
rS366228: Report the kernel console on the boot screen
Summary

Toggling is anticpated with the 'C' command, but that code isn't
written yet.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Sep 28 2020, 6:37 AM
imp created this revision.
Harbormaster completed remote builds in B33848: Diff 77586.Sep 28 2020, 6:37 AM
imp updated this revision to Diff 77587.Sep 28 2020, 6:51 AM

make toggle work

Harbormaster completed remote builds in B33849: Diff 77587.Sep 28 2020, 6:51 AM
kevans added a subscriber: kevans.Sep 28 2020, 1:51 PM
kevans added inline comments.
stand/lua/menu.lua
291 ↗(On Diff #77587)

Minor nit; it's a little uglier, but this should be color.highlight("C") .. "ons: " .. core.getConsoleName() to highlight the key alias.

imp updated this revision to Diff 77599.Sep 28 2020, 3:57 PM

Fix kyle's issue

Note: the kernel bits for reporting this also leaked into this review.

Harbormaster completed remote builds in B33857: Diff 77599.Sep 28 2020, 3:57 PM
imp updated this revision to Diff 77600.Sep 28 2020, 3:57 PM

unleak the kenrel bits

Harbormaster completed remote builds in B33858: Diff 77600.Sep 28 2020, 3:57 PM
kevans accepted this revision.Sep 28 2020, 4:01 PM

This seems to LGTM. =)

This revision is now accepted and ready to land.Sep 28 2020, 4:01 PM
Closed by commit rS366228: Report the kernel console on the boot screen (authored by imp). · Explain WhySep 28 2020, 4:19 PM
This revision was automatically updated to reflect the committed changes.
imp marked an inline comment as done.
imp added a commit: rS366228: Report the kernel console on the boot screen.

Revision Contents
Changeset List

PathSize
head/
stand/
lua/
34 lines
11 lines

Diff 77602

View Options

head/stand/lua/core.lua

Loading...
View Options

head/stand/lua/menu.lua

Loading...