Page MenuHomeFreeBSD
Differential D26550

Revert most of r360179.
ClosedPublic
Actions

Authored by jhb on Sep 24 2020, 11:10 PM.
Tags
None
Referenced Files
F166911799: D26550.id77554.diff
Mon, Aug 17, 5:34 PM
Unknown Object (File)
Mon, Aug 17, 3:43 PM
Unknown Object (File)
Sun, Aug 16, 9:44 PM
Unknown Object (File)
Sat, Aug 15, 9:15 PM
Unknown Object (File)
Fri, Aug 14, 7:50 PM
Unknown Object (File)
Fri, Aug 14, 7:29 PM
Unknown Object (File)
Fri, Aug 14, 9:56 AM
Unknown Object (File)
Wed, Aug 12, 4:06 PM
View All Files
Subscribers
imp

Details

Reviewers
scottl
Group Reviewers
cam
Commits
rS366175: Revert most of r360179.
Summary

I had failed to notice that sgsendccb() was using cam_periph_mapmem()
and thus was not passing down user pointers directly to drivers. In
practice this broke requests submitted from userland.

PR: 249395
Tested by: Trenton Schulz <trueos@norwegianrockcat.com>

Test Plan
  • submitter tested this patch, more details in the bug

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Sep 24 2020, 11:10 PM
Herald added a reviewer: cam. · View Herald TranscriptSep 24 2020, 11:10 PM
Herald added a subscriber: imp. · View Herald Transcript
jhb requested review of this revision.Sep 24 2020, 11:10 PM
Harbormaster completed remote builds in B33805: Diff 77500.Sep 24 2020, 11:10 PM
scottl accepted this revision.Sep 25 2020, 5:28 AM
This revision is now accepted and ready to land.Sep 25 2020, 5:28 AM
Closed by commit rS366175: Revert most of r360179. (authored by jhb). · Explain WhySep 25 2020, 9:20 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rS366175: Revert most of r360179..

Revision Contents
Changeset List

PathSize
head/
sys/
cam/
scsi/
25 lines

Diff 77554

View Options

head/sys/cam/scsi/scsi_sg.c

Loading...