Page MenuHomeFreeBSD

fusefs: fix mmap'd writes in direct_io mode
ClosedPublic

Authored by asomers on Sep 20 2020, 3:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 5, 10:36 PM
Unknown Object (File)
Mon, Sep 29, 7:06 PM
Unknown Object (File)
Wed, Sep 24, 2:38 PM
Unknown Object (File)
Sep 11 2025, 7:03 PM
Unknown Object (File)
Sep 4 2025, 8:12 AM
Unknown Object (File)
Aug 9 2025, 4:55 PM
Unknown Object (File)
Aug 5 2025, 5:51 PM
Unknown Object (File)
Jul 31 2025, 10:03 PM
Subscribers

Details

Summary

fusefs: fix mmap'd writes in direct_io mode

If a FUSE server returns FOPEN_DIRECT_IO in response to FUSE_OPEN, that
instructs the kernel to bypass the page cache for that file. This feature
is also known by libfuse's name: "direct_io".

However, when accessing a file via mmap, there is no possible way to bypass
the cache completely. This change fixes a deadlock that would happen when
an mmap'd write tried to invalidate a portion of the cache, wrongly assuming
that a write couldn't possibly come from cache if direct_io were set.

Arguably, we could instead disable mmap for files with FOPEN_DIRECT_IO set.
But allowing it is less likely to cause user complaints, and is more in
keeping with the spirit of open(2), where O_DIRECT instructs the kernel to
"reduce", not "eliminate" cache effects.

PR: 247276

Test Plan

regression test included

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable