Page MenuHomeFreeBSD

fusefs: fix mmap'd writes in direct_io mode
ClosedPublic

Authored by asomers on Sep 20 2020, 3:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 31, 6:49 PM
Unknown Object (File)
Mon, Aug 31, 10:52 AM
Unknown Object (File)
Sat, Aug 22, 11:11 PM
Unknown Object (File)
Fri, Aug 21, 8:31 AM
Unknown Object (File)
Wed, Aug 19, 4:30 PM
Unknown Object (File)
Tue, Aug 18, 10:34 PM
Unknown Object (File)
Tue, Aug 18, 8:36 PM
Unknown Object (File)
Tue, Aug 18, 1:17 PM
Subscribers

Details

Summary

fusefs: fix mmap'd writes in direct_io mode

If a FUSE server returns FOPEN_DIRECT_IO in response to FUSE_OPEN, that
instructs the kernel to bypass the page cache for that file. This feature
is also known by libfuse's name: "direct_io".

However, when accessing a file via mmap, there is no possible way to bypass
the cache completely. This change fixes a deadlock that would happen when
an mmap'd write tried to invalidate a portion of the cache, wrongly assuming
that a write couldn't possibly come from cache if direct_io were set.

Arguably, we could instead disable mmap for files with FOPEN_DIRECT_IO set.
But allowing it is less likely to cause user complaints, and is more in
keeping with the spirit of open(2), where O_DIRECT instructs the kernel to
"reduce", not "eliminate" cache effects.

PR: 247276

Test Plan

regression test included

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable