Page MenuHomeFreeBSD

Reduce Duplication in sys/*/include files
AcceptedPublic

Authored by pnagato_protonmail.com on Wed, Sep 2, 6:48 AM.

Details

Reviewers
imp
Summary

@imp Opening a diff for feedback/discussion

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 33349
Build 30659: arc lint + arc unit

Event Timeline

pnagato_protonmail.com requested review of this revision.Wed, Sep 2, 6:48 AM
pnagato_protonmail.com created this revision.

Added the duplication to a new file

lwhsu added a subscriber: lwhsu.Wed, Sep 2, 8:05 AM

Would it make more sense to create sys/x86/include/x86_ieeefp.h and include it in amd64/include/ieeefp.h and i386/include/ieeefp.h?

BTW, please consider submitting/updating patch with arc tool: https://wiki.freebsd.org/Phabricator

Move duplicated code under x86/include

@lwhsu Thank you, i moved the duplicated code under x86/include/x86_ieeefp.h and i was able to arc to update the diff.

Add new line and space after #include

Space after #include

lwhsu added a comment.Sat, Sep 12, 9:37 AM

@imp : ping, do you think this makes sense? It looks good to me but I'm not sure the convention is naming it x86_ieeefp.h or _ieeefp.h, I saw both under x86/include.

imp accepted this revision.Sat, Sep 12, 3:08 PM

I think this is fine

This revision is now accepted and ready to land.Sat, Sep 12, 3:08 PM
pnagato_protonmail.com retitled this revision from WIP: Reduce Duplication in sys/*/include files to Reduce Duplication in sys/*/include files.Wed, Sep 16, 3:50 AM

One final question, is the "Deprecated historical FPU control interface" comment also applicable to the remaining codes in amd64 and i386?