Page MenuHomeFreeBSD

sysutils/intel-nvmupdate: Update from 7.30 to 8.00
ClosedPublic

Authored by erj on Aug 18 2020, 9:45 PM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Output from portlint -AC:

WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: "IGNORE_DragonFly" has to appear earlier.
WARN: Makefile: "ONLY_FOR_ARCHS" has to appear earlier.
WARN: Makefile: "ONLY_FOR_ARCHS_REASON" has to appear earlier.
0 fatal errors and 4 warnings found.
erj requested review of this revision.Aug 18 2020, 9:51 PM
erj added a reviewer: skozlov.
In D26118#579726, @erj wrote:

Output from portlint -AC:

WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: "IGNORE_DragonFly" has to appear earlier.
WARN: Makefile: "ONLY_FOR_ARCHS" has to appear earlier.
WARN: Makefile: "ONLY_FOR_ARCHS_REASON" has to appear earlier.
0 fatal errors and 4 warnings found.

Please do fix those warnings. The reference for how to write a Makefile is available there https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html

Please add the poudriere testport run log

Edit Makefile to make portlint happy

In D26118#580232, @mat wrote:
In D26118#579726, @erj wrote:

Output from portlint -AC:

WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: "IGNORE_DragonFly" has to appear earlier.
WARN: Makefile: "ONLY_FOR_ARCHS" has to appear earlier.
WARN: Makefile: "ONLY_FOR_ARCHS_REASON" has to appear earlier.
0 fatal errors and 4 warnings found.

Please do fix those warnings. The reference for how to write a Makefile is available there https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html

I fixed them, but now the Makefile doesn't conform to the order that's described in the linked documentation, as far as I can tell. I had to put those three offending lines between the LICENSE variables in order to make portlint happy, whereas I think they looked like they were in the right spot before.

New portlint output:

WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 1 warning found.

New poudriere testport log:

This revision is now accepted and ready to land.Aug 24 2020, 12:42 AM
head/sysutils/intel-nvmupdate/Makefile
19–22

Those should go after the LICENSE_* variables. When portlint disagrees with the porter's handbook, portlint is wrong.