Details
Details
- Reviewers
skozlov - Commits
- rP546032: sysutils/intel-nvmupdate: Update from 7.30 to 8.00
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Output from portlint -AC:
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy. WARN: Makefile: "IGNORE_DragonFly" has to appear earlier. WARN: Makefile: "ONLY_FOR_ARCHS" has to appear earlier. WARN: Makefile: "ONLY_FOR_ARCHS_REASON" has to appear earlier. 0 fatal errors and 4 warnings found.
Comment Actions
Please do fix those warnings. The reference for how to write a Makefile is available there https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html
Comment Actions
I fixed them, but now the Makefile doesn't conform to the order that's described in the linked documentation, as far as I can tell. I had to put those three offending lines between the LICENSE variables in order to make portlint happy, whereas I think they looked like they were in the right spot before.
Comment Actions
New portlint output:
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy. 0 fatal errors and 1 warning found.
head/sysutils/intel-nvmupdate/Makefile | ||
---|---|---|
19–22 | Those should go after the LICENSE_* variables. When portlint disagrees with the porter's handbook, portlint is wrong. |