Page MenuHomeFreeBSD

Capsicumize fsck_ffs
Needs ReviewPublic

Authored by shubh on Aug 18 2020, 12:43 AM.
Referenced Files
F142721107: D26094.diff
Thu, Jan 22, 4:23 PM
Unknown Object (File)
Sun, Jan 18, 6:45 AM
Unknown Object (File)
Sun, Jan 18, 6:39 AM
Unknown Object (File)
Sat, Jan 17, 6:16 PM
Unknown Object (File)
Dec 16 2025, 2:14 AM
Unknown Object (File)
Nov 28 2025, 3:34 PM
Unknown Object (File)
Nov 26 2025, 9:51 AM
Unknown Object (File)
Nov 20 2025, 7:07 PM
Subscribers

Details

Reviewers
markj
oshogbo
Summary
  • Entered the capability mode after the setup() call is finished, because the setup() call is used in fsck_msdosfs, and hence it could interfere
  • Leveraged cap_pwd and cap_sysctl
  • Testing sysctl calls was tough, hence used the casper equivalents for all of them
Test Plan
  • Tamper a filesystem using fsdb, then test fsck_ffs

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sbin/fsck_ffs/dir.c
54

Maybe include it in fsck.h with casper.

sbin/fsck_ffs/fsck.h
297

extra line.

sbin/fsck_ffs/main.c
762

Maybe casper_init?

778

This style look weired.

782

Hym does it works? You limit to one sysctl name and then used with multiple diffrent names like:
vfs.ffs.setcwd, vfs.ffs.setdotdot.