Page MenuHomeFreeBSD

Capsicumize fsck_ffs
Needs ReviewPublic

Authored by shubh on Aug 18 2020, 12:43 AM.
Referenced Files
Unknown Object (File)
Fri, Sep 25, 5:36 AM
Unknown Object (File)
Fri, Sep 25, 5:17 AM
Unknown Object (File)
Thu, Sep 10, 12:20 PM
Unknown Object (File)
Tue, Sep 8, 6:24 AM
Unknown Object (File)
Fri, Sep 4, 12:53 AM
Unknown Object (File)
Thu, Sep 3, 9:54 AM
Unknown Object (File)
Wed, Sep 2, 10:34 AM
Unknown Object (File)
Wed, Sep 2, 8:13 AM
Subscribers

Details

Reviewers
markj
oshogbo
Summary
  • Entered the capability mode after the setup() call is finished, because the setup() call is used in fsck_msdosfs, and hence it could interfere
  • Leveraged cap_pwd and cap_sysctl
  • Testing sysctl calls was tough, hence used the casper equivalents for all of them
Test Plan
  • Tamper a filesystem using fsdb, then test fsck_ffs

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sbin/fsck_ffs/dir.c
54

Maybe include it in fsck.h with casper.

sbin/fsck_ffs/fsck.h
297

extra line.

sbin/fsck_ffs/main.c
762

Maybe casper_init?

778

This style look weired.

782

Hym does it works? You limit to one sysctl name and then used with multiple diffrent names like:
vfs.ffs.setcwd, vfs.ffs.setdotdot.