Differential D2609

sfxge: relax assertion to allow RST flag in TSO packets
ClosedPublic
Actions

Authored by arybchik on May 21 2015, 6:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Sep 16, 12:53 PM

	Unknown Object (File)
	Mon, Sep 9, 2:38 AM

	Unknown Object (File)
	Sun, Sep 8, 9:23 AM

	Unknown Object (File)
	Sun, Sep 8, 4:33 AM

	Unknown Object (File)
	Sep 1 2024, 11:24 PM

	Unknown Object (File)
	Aug 28 2024, 5:53 PM

	Unknown Object (File)
	Aug 6 2024, 2:52 AM

	Unknown Object (File)
	Jul 24 2024, 8:06 AM

View All 60 Files

Subscribers

Details

Reviewers

Commits

rS283278: sfxge: relax assertion to allow RST flag in TSO packets

Summary

Kernel under stress load, mixed MC reboot and sfupdate really
generates TSO packet with RST flag.
It will generate many TCP packets with RST flag set.
May be RST flag should be set in the last segment only, but it could be
dropped. So, it is safer to keep the flag in all packets to be sure that
connection is reset.

Sponsored by: Solarflare Communications, Inc.
MFC after: 2 days

Test Plan

Build tested. Driver loaded.
Tested using link up/down, MC (on NIC) reboot, FW update etc
under heavy TCP/UDP traffic.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arybchik updated this revision to Diff 5528.May 21 2015, 6:39 PM

arybchik retitled this revision from to sfxge: relax assertion to allow RST flag in TSO packets.

arybchik updated this object.

arybchik edited the test plan for this revision. (Show Details)

arybchik added a reviewer: gnn.

Herald added a subscriber: imp. · View Herald TranscriptMay 21 2015, 6:39 PM

arybchik added a subscriber: network.May 21 2015, 6:40 PM

gnn accepted this revision.May 21 2015, 8:51 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.May 21 2015, 8:51 PM

Closed by commit rS283278: sfxge: relax assertion to allow RST flag in TSO packets (authored by arybchik). · Explain WhyMay 22 2015, 7:39 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

10 lines

Diff 5546

head/sys/dev/sfxge/sfxge_tx.c

Loading...