Fix -Wundef warnings when building liblua
ClosedPublic
Actions

Authored by arichardson on Aug 6 2020, 5:54 PM.

Details

Reviewers

kevans
imp

Commits

rS364767: Fix -Wundef warnings when building liblua

Summary

We need to define the LUA_FLOAT_INT64 macro even if we don't use it (copied
from stand/luaconf.h). While touching luaconf.h.dist also sync it with the
the 5.3.5 release version (matches the one in lib/liblua).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson requested review of this revision.Aug 6 2020, 5:54 PM

arichardson created this revision.

Harbormaster completed remote builds in B32816: Diff 75513.Aug 6 2020, 5:54 PM

ping?

It's interesting, the luaconf.h used in lualoader *does* have these two definitions, and somehow the luaconf.h I hacked up for flua ended up with one but not the other?

Odd, but LGTM.

This revision is now accepted and ready to land.Aug 25 2020, 12:29 PM

Closed by commit rS364767: Fix -Wundef warnings when building liblua (authored by arichardson). · Explain WhyAug 25 2020, 1:30 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS364767: Fix -Wundef warnings when building liblua.

Revision Contents
Changeset List

Path

Size

head/

contrib/

lua/

src/

luaconf.h.dist

10 lines

lib/

liblua/

luaconf.h

1 line

Diff 76201

View Options

head/contrib/lua/src/luaconf.h.dist

	# Created by: Koop Mast <kwm@FreeBSD.org>			# Created by: Koop Mast <kwm@FreeBSD.org>
	# $FreeBSD$			# $FreeBSD$

	PORTNAME= libclc			PORTNAME= libclc
	DISTVERSION= 0.3.0.20170225			DISTVERSION= 0.3.0.20170927
	CATEGORIES= devel			CATEGORIES= devel

	MAINTAINER= x11@FreeBSD.org			MAINTAINER= x11@FreeBSD.org
	COMMENT= Required library functions for OpenCL C programming language			COMMENT= Required library functions for OpenCL C programming language

	LICENSE= BSD3CLAUSE MIT			LICENSE= BSD3CLAUSE MIT
	LICENSE_COMB= dual			LICENSE_COMB= dual
	LICENSE_FILE= ${WRKSRC}/LICENSE.TXT			LICENSE_FILE= ${WRKSRC}/LICENSE.TXT

	BUILD_DEPENDS= llvm${LLVMVER}>=4.0:devel/llvm${LLVMVER} \			BUILD_DEPENDS= llvm${LLVMVER}>=4.0:devel/llvm${LLVMVER} \
	libedit>=0:devel/libedit			libedit>=0:devel/libedit

	USE_GITHUB= yes			USE_GITHUB= yes
	GH_ACCOUNT= llvm-mirror			GH_ACCOUNT= llvm-mirror
	GH_TAGNAME= 17648cd			GH_TAGNAME= 81f74b2

	# ninja based build is broken since commit 598792bc (16 sep 2016)			# ninja based build is broken since commit 598792bc (16 sep 2016)
	USES= gmake python:2.7,build gmake			USES= gmake python:2.7,build gmake
	USE_LDCONFIG= yes			USE_LDCONFIG= yes
	MAKE_ENV= MAKE=${GMAKE} DESTDIR=${STAGEDIR}			MAKE_ENV= MAKE=${GMAKE} DESTDIR=${STAGEDIR}

	LLVMVER= ${MESA_LLVM_VER:U40}			LLVMVER= ${MESA_LLVM_VER:U40}

	Show All 15 Lines