Fix -Wundef warnings when building liblua
ClosedPublic
Actions

Authored by arichardson on Aug 6 2020, 5:54 PM.

Tags

None

Referenced Files

	F132389241: D25977.id75513.diff
	Thu, Oct 16, 12:07 PM

	F132309226: D25977.id76201.diff
	Wed, Oct 15, 6:33 PM

	F132309225: D25977.id75513.diff
	Wed, Oct 15, 6:33 PM

	F132309218: D25977.id.diff
	Wed, Oct 15, 6:33 PM

	Unknown Object (File)
	Wed, Oct 15, 8:05 AM

	Unknown Object (File)
	Sun, Oct 12, 3:25 PM

	Unknown Object (File)
	Tue, Oct 7, 8:10 PM

	Unknown Object (File)
	Tue, Sep 23, 12:04 AM

View All Files

Subscribers

None

Details

Reviewers

kevans
imp

Commits

rS364767: Fix -Wundef warnings when building liblua

Summary

We need to define the LUA_FLOAT_INT64 macro even if we don't use it (copied
from stand/luaconf.h). While touching luaconf.h.dist also sync it with the
the 5.3.5 release version (matches the one in lib/liblua).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson requested review of this revision.Aug 6 2020, 5:54 PM

arichardson created this revision.

Harbormaster completed remote builds in B32816: Diff 75513.Aug 6 2020, 5:54 PM

ping?

It's interesting, the luaconf.h used in lualoader *does* have these two definitions, and somehow the luaconf.h I hacked up for flua ended up with one but not the other?

Odd, but LGTM.

This revision is now accepted and ready to land.Aug 25 2020, 12:29 PM

Closed by commit rS364767: Fix -Wundef warnings when building liblua (authored by arichardson). · Explain WhyAug 25 2020, 1:30 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS364767: Fix -Wundef warnings when building liblua.