Page MenuHomeFreeBSD

mfh: Make argument parsing a bit more robust
ClosedPublic

Authored by 0mp on Aug 5 2020, 2:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 21, 7:04 AM
Unknown Object (File)
Fri, Nov 21, 7:04 AM
Unknown Object (File)
Fri, Nov 21, 7:04 AM
Unknown Object (File)
Fri, Nov 21, 7:03 AM
Unknown Object (File)
Mon, Nov 17, 5:32 AM
Unknown Object (File)
Sun, Nov 16, 11:26 PM
Unknown Object (File)
Wed, Nov 12, 2:59 AM
Unknown Object (File)
Wed, Nov 12, 2:01 AM
Subscribers

Details

Reviewers
None
Group Reviewers
portmgr
Commits
rP544225: Make argument parsing a bit more robust
Summary
Make argument parsing a bit more robust

Currently, when running mfh with a flag like --help the user gets a confusing
error message from expr(1) like the following:

> expr: illegal option -- -
> expr: usage: expr [-e] expression
>
> revision "--help" should be a number

This is not helpful. Instead, make sure that any arguments specified by the
user are handled properly by expr(1). This results in a much cleaner error
message:

> revision "--help" should be a number

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 32769
Build 30204: arc lint + arc unit

Event Timeline

0mp requested review of this revision.Aug 5 2020, 2:19 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 5 2020, 3:03 PM
This revision was automatically updated to reflect the committed changes.