Page MenuHomeFreeBSD

mfh: Make argument parsing a bit more robust
ClosedPublic

Authored by 0mp on Aug 5 2020, 2:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 16, 9:27 PM
Unknown Object (File)
Thu, Apr 16, 1:13 PM
Unknown Object (File)
Thu, Apr 16, 5:27 AM
Unknown Object (File)
Wed, Apr 15, 6:04 AM
Unknown Object (File)
Tue, Apr 14, 9:11 PM
Unknown Object (File)
Sat, Apr 11, 12:07 PM
Unknown Object (File)
Tue, Apr 7, 2:29 PM
Unknown Object (File)
Tue, Apr 7, 2:20 AM
Subscribers

Details

Reviewers
None
Group Reviewers
portmgr
Commits
rP544225: Make argument parsing a bit more robust
Summary
Make argument parsing a bit more robust

Currently, when running mfh with a flag like --help the user gets a confusing
error message from expr(1) like the following:

> expr: illegal option -- -
> expr: usage: expr [-e] expression
>
> revision "--help" should be a number

This is not helpful. Instead, make sure that any arguments specified by the
user are handled properly by expr(1). This results in a much cleaner error
message:

> revision "--help" should be a number

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp requested review of this revision.Aug 5 2020, 2:19 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 5 2020, 3:03 PM
This revision was automatically updated to reflect the committed changes.